Merge pull request #21641 from tiluckdave/fix/brew-edit-auto-tap-21585

edit: auto-tap core/cask repos when not installed

Author: MikeMcQuaid

Library/Homebrew/dev-cmd/edit.rb

@@ -53,6 +53,16 @@ def run
             [HOMEBREW_REPOSITORY]
           end
         else
+          args.named.each do |name|
+            if !args.cask? && !CoreTap.instance.installed? &&
+               Homebrew::API.formula_names.include?(name.delete_prefix("#{CoreTap.instance.name}/"))
+              CoreTap.instance.install(force: true)
+            elsif !args.formula? && !CoreCaskTap.instance.installed? &&
+                  Homebrew::API.cask_tokens.include?(name.delete_prefix("#{CoreCaskTap.instance.name}/"))
+              CoreCaskTap.instance.install(force: true)
+            end
+          end
+
           expanded_paths = args.named.to_paths
           expanded_paths.each do |path|
             raise_with_message!(path, args.cask?) unless path.exist?

Library/Homebrew/test/cli/named_args_spec.rb

@@ -358,6 +358,25 @@ def setup_unredable_cask(name)
 
       expect(described_class.new("foo", "baz").to_paths(only: :cask)).to eq [cask_path, Cask::CaskLoader.path("baz")]
     end
+
+    context "when without_api: true" do
+      it "returns a bare path for an API-known formula when the tap is not installed" do
+        allow(CoreTap.instance).to receive(:installed?).and_return(false)
+
+        require "api"
+        allow(Homebrew::API).to receive(:formula_names).and_return(["foo"])
+        allow(Homebrew::API::Formula).to receive(:all_formulae).and_return("foo" => {})
+
+        named_args = described_class.new("foo", without_api: true)
+        paths = named_args.to_paths
+
+        # to_paths returns a bare expanded path (not the core formula path) because
+        # without_api: true sets HOMEBREW_NO_INSTALL_FROM_API=1 which defeats the
+        # API name fallback check. The brew edit command works around this by
+        # auto-tapping before calling to_paths.
+        expect(paths.first.to_s).not_to match(%r{homebrew-core/Formula})
+      end
+    end
   end
 
   describe "#to_taps" do

Library/Homebrew/test/dev-cmd/edit_spec.rb

@@ -18,4 +18,31 @@
       .and not_to_output.to_stderr
       .and be_a_success
   end
+
+  it "auto-taps core when editing an API-known formula without the tap installed" do
+    (HOMEBREW_REPOSITORY/".git").mkpath
+
+    allow(CoreTap.instance).to receive(:installed?).and_return(false)
+
+    require "api"
+    allow(Homebrew::API).to receive(:formula_names).and_return(["testball"])
+    allow(Homebrew::API::Formula).to receive(:all_formulae).and_return("testball" => {})
+
+    expect(CoreTap.instance).to receive(:install).with(force: true) do
+      allow(CoreTap.instance).to receive(:installed?).and_return(true)
+      CoreTap.instance.clear_cache
+
+      formula_path = CoreTap.instance.path/"Formula"/"testball.rb"
+      formula_path.dirname.mkpath
+      formula_path.write <<~RUBY
+        class Testball < Formula
+          url "https://brew.sh/testball-1.0"
+        end
+      RUBY
+    end
+
+    allow_any_instance_of(described_class).to receive(:exec_editor)
+
+    described_class.new(["testball"]).run
+  end
 end