Merge pull request #23109 from Homebrew/upgrade-bfs-fix

cmd/upgrade: don't show upgrade size with --build-from-source

Author: MikeMcQuaid

Library/Homebrew/cmd/upgrade.rb

@@ -668,6 +668,8 @@ def formula_upgrade_display_version(formula, old_version)
 
       sig { params(formula: Formula).returns(String) }
       def formula_upgrade_size(formula)
+        return "" if args.build_from_source_formulae.include?(formula.name)
+
         bottle = formula.bottle
         return "" unless bottle
 

Library/Homebrew/test/cmd/upgrade_spec.rb

@@ -564,6 +564,24 @@ def setup_pinned_dependency_upgrade
       .to eq(["testball 0.1 -> 0.2 (500B)"])
   end
 
+  it "omits formula download sizes in dry-run source build upgrade summaries" do
+    write_formula "testball", <<~RUBY
+      url "https://brew.sh/testball-0.2"
+    RUBY
+
+    cmd = described_class.new(["--dry-run", "--build-from-source", "testball"])
+    formula = Formula["testball"]
+    bottle = instance_double(Bottle)
+    keg = instance_double(Keg, version: PkgVersion.parse("0.1"), disk_usage: 1000)
+
+    allow(formula).to receive_messages(optlinked?: true, opt_prefix: HOMEBREW_PREFIX/"opt/testball", bottle:)
+    allow(Keg).to receive(:new).with(HOMEBREW_PREFIX/"opt/testball").and_return(keg)
+    expect(bottle).not_to receive(:fetch_tab)
+
+    expect(cmd.send(:formula_upgrade_descriptions, [formula], include_sizes: true))
+      .to eq(["testball 0.1 -> 0.2"])
+  end
+
   it "prints dry-run cleanup output from one formula cleanup run" do
     formula = formula("testball") do
       T.bind(self, T.class_of(Formula))