Json: set allow_duplicate_key in JSON.parse call#21709
Merged
Merged
Conversation
`brew livecheck querious` is producing a warning in reference to the `JSON.parse` call in livecheck's `Json.parse_json` method: 'warning: detected duplicate key "prerelease" in JSON object. This will raise an error in json 3.0 unless enabled via `allow_duplicate_key: true` at line 1 column 1'. We don't have any control over upstream JSON data, so this adds an `allow_duplicate_key: true` option to the `JSON.parse` call to resolve this issue and maintain the current behavior.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Homebrew livecheck’s JSON strategy to preserve current parsing behavior when upstream JSON contains duplicate keys, avoiding warnings now and preventing failures with newer json versions.
Changes:
- Passes
allow_duplicate_key: truetoJSON.parseinLivecheck::Strategy::Json.parse_json.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZhongRuoyu
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?brew livecheck queriousis producing a warning in reference to theJSON.parsecall in livecheck'sJson.parse_jsonmethod: 'warning: detected duplicate key "prerelease" in JSON object. This will raise an error in json 3.0 unless enabled viaallow_duplicate_key: trueat line 1 column 1'. We don't have any control over upstream JSON data, so this adds anallow_duplicate_key: trueoption to theJSON.parsecall to resolve this issue and maintain the current behavior.