Skip to content

Advance internal API default#22367

Merged
MikeMcQuaid merged 1 commit into
mainfrom
internal-api-default-note
May 22, 2026
Merged

Advance internal API default#22367
MikeMcQuaid merged 1 commit into
mainfrom
internal-api-default-note

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented May 21, 2026

  • Enables HOMEBREW_USE_INTERNAL_API for users who have run a developer command, increasing coverage before it becomes default.
  • Keeps # odeprecated reminders near the env config entry and the defaulting logic.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

OpenAI Codex 5.5 xhigh with manual review.

Copilot AI review requested due to automatic review settings May 21, 2026 13:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the environment configuration documentation for HOMEBREW_USE_INTERNAL_API to leave a release-oriented reminder about potentially making the internal API the default in a future Homebrew release.

Changes:

  • Adds an odeprecated reminder comment next to HOMEBREW_USE_INTERNAL_API in EnvConfig::ENVS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/env_config.rb
@MikeMcQuaid MikeMcQuaid enabled auto-merge May 21, 2026 13:29
- Enables `HOMEBREW_USE_INTERNAL_API` for users who have run a
  developer command, increasing coverage before it becomes default.
- Keeps `# odeprecated` reminders near the env config entry and the
  defaulting logic.
@MikeMcQuaid MikeMcQuaid force-pushed the internal-api-default-note branch from 67b9afb to 2d33360 Compare May 22, 2026 12:22
@MikeMcQuaid MikeMcQuaid changed the title Note internal API default Advance internal API default May 22, 2026
Comment thread Library/Homebrew/brew.sh
@MikeMcQuaid MikeMcQuaid requested a review from issyl0 May 22, 2026 14:45
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 22, 2026
@MikeMcQuaid MikeMcQuaid removed this pull request from the merge queue due to the queue being cleared May 22, 2026
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 22, 2026
Merged via the queue into main with commit a4febc5 May 22, 2026
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the internal-api-default-note branch May 22, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants