cask/upgrade: re-register application bundle before reopen

[bevanjkay]

After a cask upgrade installs a new app bundle, open -b <bundle_id> can fail with LSCopyApplicationURLsForBundleIdentifier() failed because Launch Services hasn't re-indexed the new bundle yet.

Fix this by running lsregister on each newly installed .app artifact before attempting to reopen by bundle ID. This forces synchronous LS re-registration and has negligible overhead relative to the preceding download and install. Note: this only applies to app stanzas.

In testing this does not extend the time it takes to run brew upgrade an discernible amount.

---

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
• Have you written new tests (excluding integration tests) for your changes? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

---

• AI was used to generate or assist with generating this PR.

I used claude-code to help implement the registration of the replaced application.

---

[Copilot]

Pull request overview

This PR aims to make brew upgrade --cask more reliable when reopening applications by bundle ID after an upgrade, by forcing Launch Services to re-index newly installed .app bundles before running open -b <bundle_id>.

Changes:

• Update reopen_apps_after_upgrade to accept both old_cask and new_cask.
• Add a Launch Services re-registration step for newly installed app artifacts prior to reopening.
• Update the upgrade_cask call site to pass new_cask into the reopen helper.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[p-linnane]

Makes sense, thanks!

[MikeMcQuaid]

Thanks!