Skip to content

Avoid install warning annotations#22434

Merged
MikeMcQuaid merged 1 commit into
mainfrom
fix-install-warning-annotations
May 28, 2026
Merged

Avoid install warning annotations#22434
MikeMcQuaid merged 1 commit into
mainfrom
fix-install-warning-annotations

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

Fixes #22433

  • Keep idempotent brew install warnings visible in CI logs.
  • Avoid noisy GitHub Actions annotations for harmless installs.
  • Preserve annotation behaviour for other opoo callers.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


Copilot AI review requested due to automatic review settings May 28, 2026 07:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR keeps harmless idempotent brew install warnings visible in GitHub Actions logs without emitting workflow annotations, while preserving existing annotation behavior for other warning callers.

Changes:

  • Adds a warning helper that bypasses GitHub Actions annotations while still printing to stderr.
  • Uses the helper for “already installed and up-to-date” install paths.
  • Adds a utility output spec for the new helper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/utils/output.rb Adds opoo_without_github_actions_annotation.
Library/Homebrew/install.rb Routes selected idempotent install warnings through the new helper.
Library/Homebrew/test/utils/output_spec.rb Adds coverage for the new output helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/test/utils/output_spec.rb
- Keep idempotent `brew install` warnings visible in CI logs.
- Avoid noisy GitHub Actions annotations for harmless installs.
- Preserve annotation behaviour for other `opoo` callers.
@MikeMcQuaid MikeMcQuaid force-pushed the fix-install-warning-annotations branch from 4783947 to 9f7daa1 Compare May 28, 2026 07:54
@MikeMcQuaid MikeMcQuaid enabled auto-merge May 28, 2026 08:18
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit 0cba9a2 May 28, 2026
37 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-install-warning-annotations branch May 28, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support suppressing the "already installed" warning

3 participants