Avoid install warning annotations#22434
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR keeps harmless idempotent brew install warnings visible in GitHub Actions logs without emitting workflow annotations, while preserving existing annotation behavior for other warning callers.
Changes:
- Adds a warning helper that bypasses GitHub Actions annotations while still printing to stderr.
- Uses the helper for “already installed and up-to-date” install paths.
- Adds a utility output spec for the new helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Library/Homebrew/utils/output.rb |
Adds opoo_without_github_actions_annotation. |
Library/Homebrew/install.rb |
Routes selected idempotent install warnings through the new helper. |
Library/Homebrew/test/utils/output_spec.rb |
Adds coverage for the new output helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Keep idempotent `brew install` warnings visible in CI logs. - Avoid noisy GitHub Actions annotations for harmless installs. - Preserve annotation behaviour for other `opoo` callers.
4783947 to
9f7daa1
Compare
SMillerDev
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22433
brew installwarnings visible in CI logs.opoocallers.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local review and testing.