Skip TestFlight apps in cleanup#22439
Merged
Merged
Conversation
- Avoid uninstalling `mas list` entries with `id` zero because TestFlight apps cannot be represented in a `Brewfile`. - Cover cleanup candidates so `mas uninstall 0` is not attempted.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Brew Bundle’s Mac App Store cleanup logic to avoid treating TestFlight-installed apps (reported by mas list with id=0) as removable candidates, preventing mas uninstall 0 from being executed during brew bundle cleanup --mas.
Changes:
- Exclude
mas listentries withid=0from MAS cleanup candidates. - Extend the MAS bundle cleanup spec to include an
id=0app and assert it is not selected/uninstalled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/bundle/extensions/mac_app_store.rb | Filters out id=0 MAS entries when computing cleanup candidates. |
| Library/Homebrew/test/bundle/mac_app_store_spec.rb | Adds coverage ensuring id=0 entries are not included in cleanup/uninstall flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlocab
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22437
mas listentries withidzero because TestFlight apps cannot be represented in aBrewfile.mas uninstall 0is not attempted.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local testing and review.