Skip to content

support splitting cask versions by arch#22462

Open
TyceHerrman wants to merge 1 commit into
Homebrew:mainfrom
TyceHerrman:bump-cask-arch-version-split
Open

support splitting cask versions by arch#22462
TyceHerrman wants to merge 1 commit into
Homebrew:mainfrom
TyceHerrman:bump-cask-arch-version-split

Conversation

@TyceHerrman
Copy link
Copy Markdown

@TyceHerrman TyceHerrman commented May 29, 2026

This implements the safe root-level version split case mentioned in #21692, while preserving the manual warning for nested unsupported forms. It allows casks brew bump --open-pr -casks --auto to emit arch-specific versions when a cask's livecheck returns split versions and updates bump-cask-pr to rewrite the root version stanza into on_arm / on_intel blocks while preserving existing sha256 behavior.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

agent was used to help architect and write code, but code was reviewed by me

Teach `brew bump --open-pr --casks --auto` to pass
arch-specific version arguments when livecheck returns split versions
for a cask with one general version.

`bump-cask-pr` can then split root version and checksum stanzas,
scope replacements to the matching architecture, and keep nested
system conditionals manual.
@github-actions
Copy link
Copy Markdown

Thanks for your pull request. This has been closed because it appears to use an incomplete or outdated pull request template.

Please edit this pull request to fill in the current pull request template. This workflow will reopen this pull request automatically once the template is complete. Do not open a new pull request for this.

@github-actions github-actions Bot closed this May 29, 2026
@github-actions github-actions Bot reopened this May 29, 2026
@TyceHerrman TyceHerrman changed the title bump: support splitting cask versions by arch support splitting cask versions by arch May 29, 2026
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the motivation for this change (beyond just "samford said so", what problems it solved, what approaches you considered and rejected and how you have manually tested this yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants