support splitting cask versions by arch#22462
Open
TyceHerrman wants to merge 1 commit into
Open
Conversation
Teach `brew bump --open-pr --casks --auto` to pass arch-specific version arguments when livecheck returns split versions for a cask with one general version. `bump-cask-pr` can then split root version and checksum stanzas, scope replacements to the matching architecture, and keep nested system conditionals manual.
|
Thanks for your pull request. This has been closed because it appears to use an incomplete or outdated pull request template. Please edit this pull request to fill in the current pull request template. This workflow will reopen this pull request automatically once the template is complete. Do not open a new pull request for this. |
MikeMcQuaid
reviewed
May 30, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Can you explain the motivation for this change (beyond just "samford said so", what problems it solved, what approaches you considered and rejected and how you have manually tested this yourself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the safe root-level version split case mentioned in #21692, while preserving the manual warning for nested unsupported forms. It allows casks brew bump --open-pr -casks --auto to emit arch-specific versions when a cask's livecheck returns split versions and updates bump-cask-pr to rewrite the root version stanza into on_arm / on_intel blocks while preserving existing sha256 behavior.
brew lgtm(style, typechecking and tests) with your changes locally?agent was used to help architect and write code, but code was reviewed by me