workflows/tests.yml: skip coverage upload when brew tests is skipped#22464
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CI failures in the tests (online) matrix on push events by ensuring coverage upload steps are skipped whenever Run brew tests is intentionally skipped (so the coverage XML is not present).
Changes:
- Add the existing
Run brew testsguard condition to the Codecov test results upload step. - Add the same guard to the Codecov coverage upload step.
- Add the same guard to the GitHub
actions/upload-code-coveragestep to avoid failing on a missing coverage file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Patrick Linnane <patrick@linnane.io>
05600c5 to
34dcbfc
Compare
Code Coverage OverviewLanguages: Ruby Ruby / code-coverage/simplecovThe overall coverage remains at 78%, unchanged from the branch. Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?After merging #22451, the
tests (online)job started failing on push-to-main events.Run brew testshas an existing guard that skips tests for the online matrix on push events. No coverage files are generated in that case, but all three upload steps still ran unconditionally. The two Codecov steps tolerate missing files silently, butactions/upload-code-coverageexits 1 by default when itsfileinput doesn't exist, failing the job.This PR adds the same
if:condition to all three upload steps so they are skipped whenever Run brew tests is skipped.