Skip to content

workflows/tests.yml: skip coverage upload when brew tests is skipped#22464

Merged
MikeMcQuaid merged 1 commit into
mainfrom
fix-coverage-upload-online-push
May 30, 2026
Merged

workflows/tests.yml: skip coverage upload when brew tests is skipped#22464
MikeMcQuaid merged 1 commit into
mainfrom
fix-coverage-upload-online-push

Conversation

@p-linnane
Copy link
Copy Markdown
Member


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

After merging #22451, the tests (online) job started failing on push-to-main events. Run brew tests has an existing guard that skips tests for the online matrix on push events. No coverage files are generated in that case, but all three upload steps still ran unconditionally. The two Codecov steps tolerate missing files silently, but actions/upload-code-coverage exits 1 by default when its file input doesn't exist, failing the job.

This PR adds the same if: condition to all three upload steps so they are skipped whenever Run brew tests is skipped.

Copilot AI review requested due to automatic review settings May 30, 2026 04:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CI failures in the tests (online) matrix on push events by ensuring coverage upload steps are skipped whenever Run brew tests is intentionally skipped (so the coverage XML is not present).

Changes:

  • Add the existing Run brew tests guard condition to the Codecov test results upload step.
  • Add the same guard to the Codecov coverage upload step.
  • Add the same guard to the GitHub actions/upload-code-coverage step to avoid failing on a missing coverage file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane force-pushed the fix-coverage-upload-online-push branch from 05600c5 to 34dcbfc Compare May 30, 2026 04:03
@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented May 30, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage remains at 78%, unchanged from the branch.


Updated May 30, 2026 04:20 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 30, 2026
Merged via the queue into main with commit e570cf8 May 30, 2026
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-coverage-upload-online-push branch May 30, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants