Skip to content

feat(bash_completion): Append user-defined aliases (if any) to the list of commands#22694

Closed
yermulnik wants to merge 1 commit into
Homebrew:mainfrom
yermulnik:main
Closed

feat(bash_completion): Append user-defined aliases (if any) to the list of commands#22694
yermulnik wants to merge 1 commit into
Homebrew:mainfrom
yermulnik:main

Conversation

@yermulnik

Copy link
Copy Markdown
Contributor

Please refer to #22352 for details

Complement Bash Shell completion for top-level brew commands with user-defined aliases.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

Copilot AI review requested due to automatic review settings June 12, 2026 11:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates Homebrew’s Bash completion to include user-defined brew aliases in the command completion list.

Changes:

  • Adds an array to collect user-defined aliases and appends them to the commands list in __brew_complete_commands.
  • Adds inline comments referencing the motivating PR for the alias behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/completions/bash.erb
Comment thread Library/Homebrew/completions/bash.erb
Comment thread Library/Homebrew/completions/bash.erb
@yermulnik

Copy link
Copy Markdown
Contributor Author

Declined in favour of #22693

@yermulnik yermulnik closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants