feat(bash_completion): Append user-defined aliases (if any) to the list of commands#22694
Closed
yermulnik wants to merge 1 commit into
Closed
feat(bash_completion): Append user-defined aliases (if any) to the list of commands#22694yermulnik wants to merge 1 commit into
yermulnik wants to merge 1 commit into
Conversation
…st of commands Please refer to #22352 for details
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates Homebrew’s Bash completion to include user-defined brew aliases in the command completion list.
Changes:
- Adds an array to collect user-defined aliases and appends them to the commands list in
__brew_complete_commands. - Adds inline comments referencing the motivating PR for the alias behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Declined in favour of #22693 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to #22352 for details
Complement Bash Shell completion for top-level
brewcommands with user-defined aliases.brew lgtm(style, typechecking and tests) with your changes locally?