Skip to content

feat(bash_completion): Append user-defined aliases (if any) to the list of commands #22694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yermulnik wants to merge 1 commit into from
+11 −0
Closed

feat(bash_completion): Append user-defined aliases (if any) to the list of commands #22694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Library/Homebrew/completions/bash.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ __brew_complete_commands() {

local cur="${COMP_WORDS[COMP_CWORD]}"
local cmds
local -a cmds_user_aliases
local maintainer_cmds

if [[ -n ${__HOMEBREW_COMMANDS} ]]
Expand All @@ -129,6 +130,15 @@ __brew_complete_commands() {
then
maintainer_cmds="<%= maintainer_commands.join(" ") %>"
fi

# Append user-defined aliases (if any) to the list of commands
# Please refer to https://github.com/Homebrew/brew/pull/22352 for details
Comment thread
yermulnik marked this conversation as resolved.
while read -r cmds_user_alias
do
cmds_user_aliases+=("${cmds_user_alias}")
done < <(compgen -W "$(__brew_list_aliases)")
Comment thread
yermulnik marked this conversation as resolved.
[[ -n ${cmd_aliases[*]+"${cmd_aliases[*]}"} ]] && cmds+=" ${cmds_user_aliases[*]}"
Comment thread
yermulnik marked this conversation as resolved.

while read -r line
do
[[ $(__brew_internal_command_alias "${line}") == "${line}" ]] || continue
Expand Down Expand Up @@ -159,6 +169,7 @@ __brew_internal_command_alias() {
}

# https://github.com/Homebrew/homebrew-aliases
# Please refer to https://github.com/Homebrew/brew/pull/22352 for details
__brew_list_aliases() {
local aliases_dir="${HOME}/.brew-aliases"
local pattern="^# alias: brew ([[:alnum:]-]+)$"
Expand Down
Loading