Skip to content

test_bot/formulae: only run subset of brew tests for portable Ruby #23113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-linnane merged 1 commit into from
Jul 14, 2026
+2 −2
Merged

test_bot/formulae: only run subset of brew tests for portable Ruby #23113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Library/Homebrew/test_bot/formulae.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,11 +916,11 @@ def portable_formula!(formula_name, args:)
test "brew", "typecheck", "--update"

# Run the checks that gate a Homebrew/brew pull request.
test "brew", "style" if %w[actionlint shellcheck shfmt].all? { |f| bottled?(Formulary.factory(f)) }
test "brew", "style" unless OS.not_tier_one_configuration?
Comment thread
cho-m marked this conversation as resolved.
test "brew", "typecheck"
test "brew", "install-bundler-gems", "--groups=all"
test "brew", "vendor-gems", "--non-bundler-gems", "--no-commit"
test "brew", "tests", "--online", "--coverage"
test "brew", "tests", "--online", "--coverage", "--only=cask,formula"
Comment thread
cho-m marked this conversation as resolved.

@MikeMcQuaid MikeMcQuaid Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have tests failing on Tier 1 Linux runners? Any ideas?

@cho-m cho-m Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently failing on Gzip unpack test. I've tried a few changes to debug and see if chown could help:

Still failing on the sticky bit. I don't think we ever add it ourselves, so I'd expect the default /var/tmp sticky is causing issues in our nested directory.

Since I haven't been able to reproduce yet, I'm not able to figure out the exact conditions this happens. No issues running brew tests --only unpack_strategy/gzip on Linux VM where I spun up a Docker container (as close as I can get to CI).

@MikeMcQuaid MikeMcQuaid Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. Can we just skip that specific test in brew tests itself so we can run the test?

@cho-m cho-m Jul 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can explore again since we no longer are blocking any PRs.

I think root case is actually from running brew vendor-gems prior to tests:

brew/Library/Homebrew/dev-cmd/vendor-gems.rb

Lines 48 to 50 in df0164d

if GitHub::Actions.env_set? && HOMEBREW_PREFIX.to_s == HOMEBREW_LINUX_DEFAULT_PREFIX
ohai "chmod +t -R /home/linuxbrew/"
system "sudo", "chmod", "+t", "-R", "/home/linuxbrew/"

@cho-m cho-m Jul 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test "brew", "update-test"
test "brew", "update-test", "--to-tag"
test "brew", "update-test", "--commit=HEAD"
Expand Down
Loading