formulary: map resolves information from API#23114
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Homebrew’s API-backed formula loading to preserve patch “resolves” metadata from the formula API JSON, which helps brew vulns avoid false positives when formulas are sourced from the API rather than from Ruby files.
Changes:
- Map
patches[].resolves[].identries from API JSON into the in-memory patch resource when constructing formulas from API structs. - Extend the formulary spec to assert that
ExternalPatch#resolvesincludes IDs provided by the API (e.g., CVE + issue URL).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/formulary.rb | When building patches from API structs, passes API resolves IDs into the patch DSL via resolves(...). |
| Library/Homebrew/test/formulary_spec.rb | Adds coverage asserting that patch resolves IDs from API JSON are reflected on the resulting ExternalPatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlocab
approved these changes
Jul 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes false positives with
brew vulnswhen using the APIbrewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?