Skip to content

corepack 0.34.2 (new formula)#252890

Merged
BrewTestBot merged 2 commits into
mainfrom
corepack
Nov 5, 2025
Merged

corepack 0.34.2 (new formula)#252890
BrewTestBot merged 2 commits into
mainfrom
corepack

Conversation

@iMichka
Copy link
Copy Markdown
Member

@iMichka iMichka commented Nov 4, 2025

corepack was shipped by node at one point.
We removed the corepack formula to be consistent with that: #195770

Since node 25, corepack is not shipped anymore by node. See #252875

Thus, add the formula back ...

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to

@iMichka iMichka requested review from chenrui333 and Copilot November 4, 2025 22:44
@github-actions github-actions Bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 4, 2025
@iMichka
Copy link
Copy Markdown
Member Author

iMichka commented Nov 4, 2025

CC @chenrui333 as you removed it back then. Looks like we need to add corepack back.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the corepack formula to Homebrew after it was previously removed. Since Node.js version 25 no longer ships with corepack bundled, it needs to be available as a standalone formula. The PR adds the new corepack formula and updates conflict declarations in related formulas (yarn, pnpm, and hadoop) to prevent binary name collisions.

Key Changes:

  • Adds new corepack formula (version 0.34.2) with proper dependencies and conflict declarations
  • Removes the corepack → node rename mapping from formula_renames.json
  • Updates yarn, pnpm, and hadoop formulas to declare conflicts with the new corepack formula

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
formula_renames.json Removes the corepack→node rename entry to allow corepack as a standalone formula
Formula/c/corepack.rb New formula for corepack 0.34.2 with npm-based installation and conflict declarations
Formula/y/yarn.rb Adds conflict with corepack due to shared yarn and yarnpkg binaries
Formula/p/pnpm.rb Adds conflict with corepack due to shared pnpm and pnpx binaries
Formula/h/hadoop.rb Adds conflict with corepack due to shared yarn binaries

Comment thread Formula/p/pnpm.rb Outdated
@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented Nov 5, 2025

good callout, regarding the formula conflicts, they can come as a follow PR.

Comment thread Formula/c/corepack.rb Outdated
Comment thread Formula/c/corepack.rb Outdated
corepack was shipped by node at one point.
We removed the corepack formula to be consistent with that:
#195770

Since node 25, corepack is not shipped anymore by node.
See #252875

Thus, add the formula back ...

corepack: fix syntax issue

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge November 5, 2025 05:47
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit da9bd78 Nov 5, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the corepack branch November 5, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants