refactor repo to make it modular and use docker#21
Merged
Conversation
Mirror the llvm-custom build setup: a prebuilt ndk-builder image bakes the
toolchains (zig, llvm-mingw, zig-as-llvm) plus p7zip + python3.11, and a single
env-driven scripts/make-ndk.sh does build-deps + assemble + archive for all four
platforms. The four make_ndk_* workflows become thin callers of a reusable
make-ndk.yml that runs the script in the container.
Behavior is preserved 1:1 (per-platform flags, host-dir renames, cmake/ndk
fixups, archive formats). zig is added to PATH so the zig-as-llvm wrappers
resolve it (previously provided by the setup-zig action).
- docker/Dockerfile, .github/workflows/docker-image.yml: build + publish image
- scripts/make-ndk.sh: orchestrator, case "$PLATFORM"
- .github/workflows/make-ndk.yml: reusable matrix workflow
- make_ndk_{bionic,musl,bsd,windows}.yml: thin callers
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
build_python() does mkdir -p build but never cd build, so --prefix=\C:\Users\Homura\GitHub\android-ndk-custom-experimental/build resolves to \/python/build/, putting the installed binary at build/bin/python3.11. The old paths referenced build/python which never existed. Also removed the || echo WARNING on make build_all so build failures are no longer silently masked.
HomuHomu833
added a commit
that referenced
this pull request
Jun 6, 2026
HomuHomu833
added a commit
that referenced
this pull request
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.