Fix a placeholder issue in the first selection attempt

AgustinBonilla · AgustinBonilla · commit 4d6742cc4967 · 2021-08-06T20:03:00.000-03:00
diff --git a/src/MaterialDesignControls.iOS/Renderers/MaterialPickerRenderer.cs b/src/MaterialDesignControls.iOS/Renderers/MaterialPickerRenderer.cs
@@ -21,6 +21,7 @@ public static void Init() { }
         protected override void OnElementChanged(ElementChangedEventArgs<Xamarin.Forms.Picker> e)
         {
             base.OnElementChanged(e);
+
             if (this.Control != null)
             {
                 this.Control.BorderStyle = UITextBorderStyle.None;
@@ -54,7 +55,7 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE
             var customPicker = (CustomPicker)Element;
             if (e.PropertyName == nameof(customPicker.SelectedIndex))
             {
-                if (customPicker.SelectedItem == null && !string.IsNullOrEmpty(customPicker.Placeholder))
+                if (customPicker.SelectedItem == null && Control.Text == null && !string.IsNullOrEmpty(customPicker.Placeholder))
                 {
                     this.Control.Text = null;
                     this.Control.AttributedPlaceholder = new NSAttributedString(customPicker.Placeholder, foregroundColor: customPicker.PlaceholderColor.ToUIColor());

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ public static void Init() { }`
`21`	`21`	`protected override void OnElementChanged(ElementChangedEventArgs<Xamarin.Forms.Picker> e)`
`22`	`22`	`{`
`23`	`23`	`base.OnElementChanged(e);`
	`24`	`+`
`24`	`25`	`if (this.Control != null)`
`25`	`26`	`{`
`26`	`27`	`this.Control.BorderStyle = UITextBorderStyle.None;`
`@@ -54,7 +55,7 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE`
`54`	`55`	`var customPicker = (CustomPicker)Element;`
`55`	`56`	`if (e.PropertyName == nameof(customPicker.SelectedIndex))`
`56`	`57`	`{`
`57`		`- if (customPicker.SelectedItem == null && !string.IsNullOrEmpty(customPicker.Placeholder))`
	`58`	`+ if (customPicker.SelectedItem == null && Control.Text == null && !string.IsNullOrEmpty(customPicker.Placeholder))`
`58`	`59`	`{`
`59`	`60`	`this.Control.Text = null;`
`60`	`61`	`this.Control.AttributedPlaceholder = new NSAttributedString(customPicker.Placeholder, foregroundColor: customPicker.PlaceholderColor.ToUIColor());`