fix(build): propagate HAS_STRING_VIEW=1 to library consumers#910
Open
ancieg wants to merge 1 commit intoHowardHinnant:masterfrom
Open
fix(build): propagate HAS_STRING_VIEW=1 to library consumers#910ancieg wants to merge 1 commit intoHowardHinnant:masterfrom
ancieg wants to merge 1 commit intoHowardHinnant:masterfrom
Conversation
Ensure that both the library and its clients use the same ABI for locate_zone (std::string_view overload). Previously, the macro was defined only when building the library, causing linker errors for projects that consumed the shared library without the same define. Add target_compile_definitions(date-tz INTERFACE HAS_STRING_VIEW=1) to force consistent definition across all dependencies. Ref: HowardHinnant#398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that both the library and its clients use the same ABI for locate_zone (std::string_view overload). Previously, the macro was defined only when building the library, causing linker errors for projects that consumed the shared library without the same define.
Add target_compile_definitions(date-tz INTERFACE HAS_STRING_VIEW=1) to force consistent definition across all dependencies.
Ref: #398