cleanup

Author: rbri

src/main/java/org/htmlunit/cyberneko/HTMLScanner.java

@@ -844,29 +844,31 @@ else if (featureId.equals(ALLOW_SELFCLOSING_TAGS)) {
     /** Sets a property. */
     @Override
     public void setProperty(final String propertyId, final Object value) throws XMLConfigurationException {
-        if (propertyId.equals(NAMES_ELEMS)) {
-            fNamesElems = getNamesValue(String.valueOf(value));
-        }
-        else if (propertyId.equals(NAMES_ATTRS)) {
-            fNamesAttrs = getNamesValue(String.valueOf(value));
-        }
-        else if (propertyId.equals(DEFAULT_ENCODING)) {
-            fDefaultIANAEncoding = String.valueOf(value);
-        }
-        else if (propertyId.equals(ERROR_REPORTER)) {
-            fErrorReporter = (HTMLErrorReporter) value;
-        }
-        else if (propertyId.equals(ENCODING_TRANSLATOR)) {
-            fEncodingTranslator = (EncodingTranslator) value;
-        }
-        else if (propertyId.equals(DOCTYPE_PUBID)) {
-            fDoctypePubid = String.valueOf(value);
-        }
-        else if (propertyId.equals(DOCTYPE_SYSID)) {
-            fDoctypeSysid = String.valueOf(value);
-        }
-        else if (propertyId.equals(READER_BUFFER_SIZE)) {
-            fReaderBufferSize = Integer.parseInt(String.valueOf(value));
+        switch (propertyId) {
+            case NAMES_ELEMS:
+                fNamesElems = getNamesValue(String.valueOf(value));
+                break;
+            case NAMES_ATTRS:
+                fNamesAttrs = getNamesValue(String.valueOf(value));
+                break;
+            case DEFAULT_ENCODING:
+                fDefaultIANAEncoding = String.valueOf(value);
+                break;
+            case ERROR_REPORTER:
+                fErrorReporter = (HTMLErrorReporter) value;
+                break;
+            case ENCODING_TRANSLATOR:
+                fEncodingTranslator = (EncodingTranslator) value;
+                break;
+            case DOCTYPE_PUBID:
+                fDoctypePubid = String.valueOf(value);
+                break;
+            case DOCTYPE_SYSID:
+                fDoctypeSysid = String.valueOf(value);
+                break;
+            case READER_BUFFER_SIZE:
+                fReaderBufferSize = Integer.parseInt(String.valueOf(value));
+                break;
         }
     }
 

src/main/java/org/htmlunit/cyberneko/HTMLTagBalancer.java

@@ -386,17 +386,16 @@ else if ("svg".equalsIgnoreCase(qname.getLocalpart())) {
     public void setFeature(final String featureId, final boolean state)
         throws XMLConfigurationException {
 
-        if (featureId.equals(AUGMENTATIONS)) {
-            fAugmentations = state;
-            return;
-        }
-        if (featureId.equals(REPORT_ERRORS)) {
-            fReportErrors = state;
-            return;
-        }
-        if (featureId.equals(IGNORE_OUTSIDE_CONTENT)) {
-            fIgnoreOutsideContent = state;
-            return;
+        switch (featureId) {
+            case AUGMENTATIONS:
+                fAugmentations = state;
+                return;
+            case REPORT_ERRORS:
+                fReportErrors = state;
+                return;
+            case IGNORE_OUTSIDE_CONTENT:
+                fIgnoreOutsideContent = state;
+                return;
         }
     }
 

src/main/java/org/htmlunit/cyberneko/util/FastHashMap.java

@@ -27,7 +27,7 @@
  * Simple hash map implementation taken from here
  * https://github.com/mikvor/hashmapTest/blob/master/src/main/java/map/objobj/ObjObjMap.java
  * No concrete license specified at the source. The project is public domain.
- *
+ * <p>
  * Not thread-safe! Null support was removed.
  *
  * @param <K> the type of the key
@@ -340,7 +340,7 @@ private void readObject(final ObjectInputStream aInputStream) throws ClassNotFou
         clear();
 
         // sort things in, so we get a nice clean new map, this will
-        // also cleanup what was previously a removed entry, we have not
+        // also clean up what was previously a removed entry, we have not
         // kept that information anyway
         for (int i = 0; i < srcData.length; i += 2) {
             final Object key = srcData[i];

src/main/java/org/htmlunit/cyberneko/xerces/dom/AttrImpl.java

@@ -302,7 +302,7 @@ public void setValue(final String newvalue) {
 
         // Create and add the new one, generating only non-aggregate events
         // (There are no listeners on the new Text, but there may be
-        // capture/bubble listeners on the Attr.
+        // capture/bubble listeners on the Attr).
         // Note that aggregate events are NOT dispatched here,
         // since we need to combine the remove and insert.
         isSpecified(true);
@@ -513,7 +513,7 @@ Node internalInsertBefore(final Node newChild, Node refChild, final boolean repl
             // have been transferred. (Alternative behaviors would be to
             // reparent up to the first failure point or reparent all those
             // which are acceptable to the target node, neither of which is
-            // as robust. PR-DOM-0818 isn't entirely clear on which it
+            // as robust.) PR-DOM-0818 isn't entirely clear on which it
             // recommends?????
 
             // No need to check kids for right-document; if they weren't,

src/main/java/org/htmlunit/cyberneko/xerces/dom/ElementNSImpl.java

@@ -59,7 +59,7 @@ private void setName(final String namespaceURI, final String qname) {
         // 1. if the qualified name is 'null' it is malformed.
         // 2. or if the qualifiedName is null and the namespaceURI is different from
         // null,
-        // We dont need to check for namespaceURI != null, if qualified name is null
+        // We don't need to check for namespaceURI != null, if qualified name is null
         // throw DOMException.
         if (qname == null) {
             final String msg = DOMMessageFormatter.formatMessage("NAMESPACE_ERR", null);

src/main/java/org/htmlunit/cyberneko/xerces/dom/EntityImpl.java

@@ -195,7 +195,7 @@ public void setXmlEncoding(final String value) {
      *
      * An attribute specifying the encoding used for this entity at the tiome of
      * parsing, when it is an external parsed entity. This is <code>null</code> if
-     * it an entity from the internal subset or if it is not known..
+     * it is an entity from the internal subset or if it is not known.
      */
     @Override
     public String getInputEncoding() {

src/main/java/org/htmlunit/cyberneko/xerces/dom/EntityReferenceImpl.java

@@ -47,7 +47,7 @@
  * synchronized with its parent. This leads me back to the "cached image of
  * centrally defined data" solution, much as I dislike it.
  * <P>
- * For now I have decided, since REC-DOM-Level-1-19980818 doesn't cover this in
+ * For now, I have decided, since REC-DOM-Level-1-19980818 doesn't cover this in
  * much detail, that synchronization doesn't have to be considered while the
  * user is deep in the tree. That is, if you're looking within one of the
  * EntityReferennce's children and the Entity changes, you won't be informed;

src/main/java/org/htmlunit/cyberneko/xerces/parsers/AbstractDOMParser.java

@@ -263,7 +263,7 @@ public void processingInstruction(final String target, final XMLString data,
      * @param namespaceContext The namespace context in effect at the start of this
      *                         document. This object represents the current context.
      *                         Implementors of this class are responsible for
-     *                         copying the namespace bindings from the the current
+     *                         copying the namespace bindings from the current
      *                         context (and its parent contexts) if that information
      *                         is important.
      * @param augs             Additional information that may include infoset

src/main/java/org/htmlunit/cyberneko/xerces/parsers/AbstractSAXParser.java

@@ -125,7 +125,7 @@ protected AbstractSAXParser(final XMLParserConfiguration config) {
      * @param namespaceContext The namespace context in effect at the start of this
      *                         document. This object represents the current context.
      *                         Implementors of this class are responsible for
-     *                         copying the namespace bindings from the the current
+     *                         copying the namespace bindings from the current
      *                         context (and its parent contexts) if that information
      *                         is important.
      * @param augs             Additional information that may include infoset

src/main/java/org/htmlunit/cyberneko/xerces/util/ErrorHandlerWrapper.java

@@ -56,7 +56,7 @@ public ErrorHandler getErrorHandler() {
      *
      * @param domain    The domain of the warning. The domain can be any string but
      *                  is suggested to be a valid URI. The domain can be used to
-     *                  conveniently specify a web site location of the relevent
+     *                  conveniently specify a website location of the relevant
      *                  specification or document pertaining to this warning.
      * @param key       The warning key. This key can be any string and is
      *                  implementation dependent.
@@ -90,7 +90,7 @@ public void warning(final String domain, final String key, final XMLParseExcepti
      *
      * @param domain    The domain of the error. The domain can be any string but is
      *                  suggested to be a valid URI. The domain can be used to
-     *                  conveniently specify a web site location of the relevent
+     *                  conveniently specify a website location of the relevant
      *                  specification or document pertaining to this error.
      * @param key       The error key. This key can be any string and is
      *                  implementation dependent.
@@ -130,7 +130,7 @@ public void error(final String domain, final String key, final XMLParseException
      *
      * @param domain    The domain of the fatal error. The domain can be any string
      *                  but is suggested to be a valid URI. The domain can be used
-     *                  to conveniently specify a web site location of the relevent
+     *                  to conveniently specify a website location of the relevant
      *                  specification or document pertaining to this fatal error.
      * @param key       The fatal error key. This key can be any string and is
      *                  implementation dependent.