minor optimizations

Author: rbri

src/main/java/org/htmlunit/cyberneko/HTMLTagBalancer.java

@@ -446,6 +446,7 @@ public void startDocument(final XMLLocator locator, final String encoding,
 
         // reset state
         fElementStack.clear();
+
         if (fragmentContextStack_ != null) {
             fragmentContextStackSize_ = fragmentContextStack_.length;
             // use indexed loop to avoid Iterator allocation
@@ -818,7 +819,7 @@ else if (!fSeenRootElement && !fDocumentFragment) {
                     fErrorReporter.reportWarning("HTML2002", new Object[]{ename, pname});
                 }
                 final QName qname = createQName(pname);
-                final boolean parentCreated = forceStartElement(qname, fEmptyXMLAttributes, synthesizedAugs());
+                final boolean parentCreated = forceStartElementParentCreated(qname, fEmptyXMLAttributes, synthesizedAugs());
                 if (!parentCreated) {
                     if (!isForcedCreation) {
                         notifyDiscardedStartElement(elem, attrs, augs);
@@ -838,7 +839,7 @@ else if (!fSeenRootElement && !fDocumentFragment) {
                         }
 
                         final QName qname = createQName(pname);
-                        final boolean parentCreated = forceStartElement(qname, fEmptyXMLAttributes, synthesizedAugs());
+                        final boolean parentCreated = forceStartElementParentCreated(qname, fEmptyXMLAttributes, synthesizedAugs());
                         if (!parentCreated) {
                             if (!isForcedCreation) {
                                 notifyDiscardedStartElement(elem, attrs, augs);
@@ -964,14 +965,25 @@ else if (!fTemplateFragment && elementCode == HTMLElements.SELECT) {
      * the element has been forced.
      * @return <code>true</code> if creation could be done (TABLE's creation for instance can't be forced)
      */
-    private boolean forceStartElement(final QName elem, final XMLAttributes attrs,
+    private boolean forceStartElementParentCreated(final QName elem, final XMLAttributes attrs,
                         final Augmentations augs) throws XNIException {
         forcedStartElement_ = true;
         startElement(elem, attrs, augs);
 
         return fElementStack.length > 0 && elem.equals(fElementStack.peek().qname);
     }
 
+    /**
+     * Forces an element start, taking care to set the information to allow startElement to "see" that's
+     * the element has been forced.
+     * @return <code>true</code> if creation could be done (TABLE's creation for instance can't be forced)
+     */
+    private void forceStartElement(final QName elem, final XMLAttributes attrs,
+                        final Augmentations augs) throws XNIException {
+        forcedStartElement_ = true;
+        startElement(elem, attrs, augs);
+    }
+
     private static QName createQName(final String tagName) {
         return new QName(null, tagName, tagName, NamespaceBinder.XHTML_1_0_URI);
     }
@@ -1162,7 +1174,11 @@ public void endElement(final QName element, final Augmentations augs) throws XNI
         }
 
         // check for end of document
-        if (elementCode == HTMLElements.HTML) {
+        if (elementCode == HTMLElements.BR) {
+            forceStartElement(element, fEmptyXMLAttributes, synthesizedAugs());
+            return;
+        }
+        else if (elementCode == HTMLElements.HTML) {
             fSeenRootElementEnd = true;
         }
         else if (fIgnoreOutsideContent) {
@@ -1196,10 +1212,6 @@ else if (elementCode == HTMLElements.HEAD && !isForcedEndElement) {
                 endElement(element, augs);
                 return;
             }
-            if (elementCode == HTMLElements.BR) {
-                forceStartElement(element, fEmptyXMLAttributes, synthesizedAugs());
-                return;
-            }
 
             // Headings: if a heading end tag appears but there is no matching open tag,
             // close the nearest open heading (H1..H6).
@@ -1239,12 +1251,7 @@ else if (elementCode == HTMLElements.HEAD && !isForcedEndElement) {
     }
 
     private static boolean isHeading(final short code) {
-        return code == HTMLElements.H1
-                || code == HTMLElements.H2
-                || code == HTMLElements.H3
-                || code == HTMLElements.H4
-                || code == HTMLElements.H5
-                || code == HTMLElements.H6;
+        return HTMLElements.H1 <= code && code <= HTMLElements.H6;
     }
 
     /**
@@ -1552,7 +1559,7 @@ public Info pop() {
 
         // Resets the stack and releases all Info references so they can be GC'd.
         public void clear() {
-            Arrays.fill(data, 0, length, null);
+            Arrays.fill(data, null);
             length = 0;
         }