simplify code and one more test

rbri · rbri · commit a8247f181ca3 · 2026-07-26T17:05:04.000+02:00
diff --git a/src/main/java/org/htmlunit/cyberneko/HTMLTagBalancer.java b/src/main/java/org/htmlunit/cyberneko/HTMLTagBalancer.java
@@ -858,22 +858,6 @@ else if (!fTemplateFragment && elementCode == HTMLElements.SELECT) {
             fOpenedSelect = true;
         }
 
-        // if block element, save immediate parent formatting elements
-        int depth = 0;
-        if (element.flags == 0) {
-            final int length = fElementStack.length;
-            fFormattingStack.length = 0;
-            for (int i = length - 1; i >= 0; i--) {
-                final Info info = fElementStack.data[i];
-                if (!info.element.isFormatting()) {
-                    break;
-                }
-                fFormattingStack.push(info);
-                endElement(info.qname, synthesizedAugs());
-            }
-            depth = fFormattingStack.length;
-        }
-
         // close previous elements
         // all elements close a <script>
         // in head, no element has children
@@ -949,12 +933,6 @@ else if (!fTemplateFragment && elementCode == HTMLElements.SELECT) {
             }
         }
 
-        // re-open formatting elements
-        for (int i = 0; i < depth; i++) {
-            final Info info = fFormattingStack.pop();
-            forceStartElement(info.qname, info.attributes, synthesizedAugs());
-        }
-
         if (elementCode == HTMLElements.BODY) {
             lostText_.refeed(this);
         }
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html b/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html
@@ -0,0 +1 @@
+<b>bold text before<div>a block element</div>bold text after</b>
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical b/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical
@@ -0,0 +1,13 @@
+(html
+(head
+)head
+(body
+(b
+"bold text before
+(div
+"a block element
+)div
+"bold text after
+)b
+)body
+)html
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical-frg b/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical-frg
@@ -0,0 +1,7 @@
+(b
+"bold text before
+(div
+"a block element
+)div
+"bold text after
+)b
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical-html b/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical-html
@@ -0,0 +1 @@
+<html><head></head><body><b>bold text before<div>a block element</div>bold text after</b></body></html>
diff --git a/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical-xni b/src/test/resources/org/htmlunit/cyberneko/testfiles/b/test-div-inside-b.html.canonical-xni
@@ -0,0 +1,17 @@
+startDocument [(1,1,0) (1,1,0) false]
+startElement (localpart="html",rawname="html",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+startElement (localpart="head",rawname="head",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+endElement (localpart="head",rawname="head",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+startElement (localpart="body",rawname="body",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+startElement (localpart="b",rawname="b") [(1,1,0) (1,4,3) false]
+characters 'bold text before'[(1,4,3) (1,20,19) false]
+startElement (localpart="div",rawname="div") [(1,20,19) (1,25,24) false]
+characters 'a block element'[(1,25,24) (1,40,39) false]
+endElement (localpart="div",rawname="div") [(1,40,39) (1,46,45) false]
+characters 'bold text after'[(1,46,45) (1,61,60) false]
+endElement (localpart="b",rawname="b") [(1,61,60) (1,65,64) false]
+characters '
+'[(1,65,64) (2,1,65) false]
+endElement (localpart="body",rawname="body",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+endElement (localpart="html",rawname="html",uri="http://www.w3.org/1999/xhtml") [(-1,-1,-1) (-1,-1,-1) true]
+endDocument [(2,1,65) (2,1,65) false]

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<b>bold text before<div>a block element</div>bold text after</b>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<html><head></head><body><b>bold text before<div>a block element</div>bold text after</b></body></html>`