Skip to content

Commit 4c1bfe4

Browse files
committed
and more detailed plugin update tests
1 parent 09fdd53 commit 4c1bfe4

1 file changed

Lines changed: 22 additions & 1 deletion

File tree

src/test/java/org/htmlunit/ExternalTest.java

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,15 +102,30 @@ public void pom() throws Exception {
102102
for (var plugin : model.getBuild().getPlugins()) {
103103
checkVersion(plugin.getGroupId(), plugin.getArtifactId(), plugin.getVersion(),
104104
model, ignorePattern, wrongVersions);
105+
106+
// NEW: check dependencies declared inside the plugin itself
107+
if (plugin.getDependencies() != null) {
108+
for (var dep : plugin.getDependencies()) {
109+
checkVersion(dep.getGroupId(), dep.getArtifactId(), dep.getVersion(),
110+
model, ignorePattern, wrongVersions);
111+
}
112+
}
105113
}
106114
}
107115

108-
// Plugins declared under <build><pluginManagement><plugins>
109116
if (model.getBuild().getPluginManagement() != null
110117
&& model.getBuild().getPluginManagement().getPlugins() != null) {
111118
for (var plugin : model.getBuild().getPluginManagement().getPlugins()) {
112119
checkVersion(plugin.getGroupId(), plugin.getArtifactId(), plugin.getVersion(),
113120
model, ignorePattern, wrongVersions);
121+
122+
// NEW
123+
if (plugin.getDependencies() != null) {
124+
for (var dep : plugin.getDependencies()) {
125+
checkVersion(dep.getGroupId(), dep.getArtifactId(), dep.getVersion(),
126+
model, ignorePattern, wrongVersions);
127+
}
128+
}
114129
}
115130
}
116131
}
@@ -311,6 +326,12 @@ private static boolean isIgnored(final String groupId, final String artifactId,
311326
return true;
312327
}
313328

329+
// spotbugs 13 requires jdk 21
330+
if ("checkstyle".equals(artifactId)
331+
&& (version.startsWith("13."))) {
332+
return true;
333+
}
334+
314335
// ancient common versions
315336
if ("commons-io".equals(artifactId) && (version.startsWith("2003"))) {
316337
return true;

0 commit comments

Comments
 (0)