check also the plugins for new version

Author: rbri

pom.xml

@@ -84,7 +84,7 @@
         <build-helper-plugin.version>3.6.1</build-helper-plugin.version>
         <checkstyle-plugin.version>3.6.0</checkstyle-plugin.version>
         <pmd-plugin.version>3.28.0</pmd-plugin.version>
-        <spotbugs-plugin.version>4.10.2.0</spotbugs-plugin.version>
+        <spotbugs-plugin.version>4.10.3.0</spotbugs-plugin.version>
         <gpg-plugin.version>3.2.8</gpg-plugin.version>
         <enforcer-plugin.version>3.6.3</enforcer-plugin.version>
         <changes-plugin.version>2.12.1</changes-plugin.version>
@@ -98,7 +98,7 @@
         <bundle-plugin.version>6.0.2</bundle-plugin.version>
         <jacoco-plugin.version>0.8.15</jacoco-plugin.version>
         <jdepend-plugin.version>2.2.0</jdepend-plugin.version>
-        <cyclonedx-plugin.version>2.9.1</cyclonedx-plugin.version>
+        <cyclonedx-plugin.version>2.9.2</cyclonedx-plugin.version>
     </properties>
 
     <build>

src/test/java/org/htmlunit/ExternalTest.java

@@ -89,24 +89,57 @@ public void pom() throws Exception {
             final Pattern ignorePattern = Pattern.compile("" + model.getProperties().get("maven.version.ignore"));
 
             final List<String> wrongVersions = new LinkedList<>();
+
+            // Dependencies
             for (var dep : model.getDependencies()) {
-                String version = dep.getVersion();
-                if (version.startsWith("${")) {
-                    version = "" + model.getProperties().get(version.substring(2, version.length() - 1));
-                }
-                try {
-                    assertVersion(dep.getGroupId(), dep.getArtifactId(), version, ignorePattern);
+                checkVersion(dep.getGroupId(), dep.getArtifactId(), dep.getVersion(),
+                        model, ignorePattern, wrongVersions);
+            }
+
+            // Plugins declared directly under <build><plugins>
+            if (model.getBuild() != null) {
+                if (model.getBuild().getPlugins() != null) {
+                    for (var plugin : model.getBuild().getPlugins()) {
+                        checkVersion(plugin.getGroupId(), plugin.getArtifactId(), plugin.getVersion(),
+                                model, ignorePattern, wrongVersions);
+                    }
                 }
-                catch (final AssertionError e) {
-                    wrongVersions.add(e.getMessage());
+
+                // Plugins declared under <build><pluginManagement><plugins>
+                if (model.getBuild().getPluginManagement() != null
+                        && model.getBuild().getPluginManagement().getPlugins() != null) {
+                    for (var plugin : model.getBuild().getPluginManagement().getPlugins()) {
+                        checkVersion(plugin.getGroupId(), plugin.getArtifactId(), plugin.getVersion(),
+                                model, ignorePattern, wrongVersions);
+                    }
                 }
             }
+
             if (!wrongVersions.isEmpty()) {
                 Assertions.fail(String.join("\n ", wrongVersions));
             }
         }
     }
 
+    private static void checkVersion(String groupId, String artifactId, String rawVersion,
+                            Model model, Pattern ignorePattern, List<String> wrongVersions) throws Exception {
+        if (rawVersion == null) {
+            // e.g. version inherited from a parent/BOM - nothing to resolve locally
+            return;
+        }
+
+        String version = rawVersion;
+        if (version.startsWith("${")) {
+            version = "" + model.getProperties().get(version.substring(2, version.length() - 1));
+        }
+
+        try {
+            assertVersion(groupId, artifactId, version, ignorePattern);
+        } catch (final AssertionError e) {
+            wrongVersions.add(e.getMessage());
+        }
+    }
+
     /**
      * Tests that we use the latest chrome driver.
      * @throws Exception if an error occurs
@@ -219,6 +252,7 @@ public void snapshot() throws Exception {
     private static void assertVersion(final String groupId, final String artifactId,
                             final String pomVersion, final Pattern ignorePattern)
             throws Exception {
+System.out.println("assertVersion(" + groupId);
         String latestMavenCentralVersion = null;
         String url = MAVEN_REPO_URL_
                         + groupId.replace('.', '/') + '/'
@@ -270,7 +304,10 @@ private static boolean isIgnored(final String groupId, final String artifactId,
             final String version, final Pattern ignorePattern) {
         // version > 3.12.0 does not work with our site.xml and also not with a refactored one
         if ("maven-site-plugin".equals(artifactId)
-                && (version.startsWith("3.12.1") || version.startsWith("3.20.") || version.startsWith("3.21."))) {
+                && (version.startsWith("3.12.1")
+                        || version.startsWith("3.20.")
+                        || version.startsWith("3.21.")
+                        || version.startsWith("3.22."))) {
             return true;
         }