fix tests

Author: rbri

pom.xml

@@ -46,10 +46,11 @@
         <selenium.devtools.artifactId>selenium-devtools-v136</selenium.devtools.artifactId>
 
         <!-- test dependencies -->
-        <junit.version>5.13.0</junit.version>
+        <junit.version>5.13.1</junit.version>
+        <junit-launcher.version>1.13.1</junit-launcher.version>
         <jetty.version>9.4.57.v20241219</jetty.version>
         <quercus.version>4.0.66</quercus.version>
-        <log4j.version>2.24.3</log4j.version>
+        <log4j.version>2.25.0</log4j.version>
         <slf4j.version>2.0.17</slf4j.version>
         <commons-text.version>1.13.1</commons-text.version>
         <commons-fileupload.version>1.6.0</commons-fileupload.version>
@@ -1328,7 +1329,7 @@
         <dependency>
             <groupId>org.junit.platform</groupId>
             <artifactId>junit-platform-launcher</artifactId>
-            <version>1.13.0</version>
+            <version>${junit-launcher.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>

src/test/java/org/htmlunit/CodeStyleTest.java

@@ -40,6 +40,7 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -926,6 +927,7 @@ private void testTests(final File dir) throws Exception {
                                             && method.getAnnotation(AfterEach.class) == null
                                             && method.getAnnotation(AfterAll.class) == null
                                             && method.getAnnotation(Test.class) == null
+                                            && method.getAnnotation(RepeatedTest.class) == null
                                             && method.getReturnType() == Void.TYPE
                                             && method.getParameterTypes().length == 0) {
                                         final List<String> lines = FileUtils.readLines(file, SOURCE_ENCODING);

src/test/java/org/htmlunit/ErrorOutputChecker.java

@@ -23,8 +23,9 @@
 import org.junit.jupiter.api.extension.AfterEachCallback;
 import org.junit.jupiter.api.extension.BeforeEachCallback;
 import org.junit.jupiter.api.extension.ExtensionContext;
+
 /**
- * JUnit 4 {@link org.junit.Rule} verifying that nothing is printed to {@link System#err}
+ * JUnit callback verifying that nothing is printed to {@link System#err}
  * during test execution. If this is the case, the rule generates a failure for
  * the unit test.
  *

src/test/java/org/htmlunit/ExternalTest.java

@@ -268,7 +268,7 @@ private static void assertVersion(final String groupId, final String artifactId,
 
             // it is ok if the pom uses a more recent version
             if (!isVersionAfter(pomVersion, latestMavenCentralVersion)) {
-                Assertions.assertEquals(/* groupId + ":" + artifactId, */ latestMavenCentralVersion, pomVersion);
+                Assertions.assertEquals(latestMavenCentralVersion, pomVersion, groupId + ":" + artifactId);
             }
         }
     }

src/test/java/org/htmlunit/javascript/ThreadTest.java

@@ -38,7 +38,7 @@ public class ThreadTest {
     /**
      * @throws InterruptedException if the test fails
      */
-    public void testJavaScriptEngineInMultipleThreads() throws InterruptedException {
+    private void testJavaScriptEngineInMultipleThreads() throws InterruptedException {
         final TestThread thread1 = new TestThread("thread1");
         final TestThread thread2 = new TestThread("thread2");
         final TestThread thread3 = new TestThread("thread3");