more minor fixes for input/text area value and selection handling + many more detailed tests

rbri · rbri · commit bbf5c94ea927 · 2026-07-31T09:01:14.000+02:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,8 +8,20 @@
 
     <body>
         <release version="5.4.0" date="August xx, 2026" description="Firefox 153, Bugfixes">
+            <action type="fix" dev="rbri">
+                Fixed HtmlTextArea.reset(): the text entry cursor/selection is now only moved to the end of the restored
+                value when that value actually differs from the current one, instead of always being forced to the end.
+            </action>
+            <action type="fix" dev="rbri">
+                Fixed HtmlInput/HtmlSelectableTextInput: setting the value to the value it already holds no longer moves
+                the text entry cursor/selection to the end, mirroring the same fix applied to HtmlTextArea.
+            </action>
+            <action type="fix" dev="rbri">
+                Fixed HtmlSelectableTextInput.reset(): removed a leftover selection reset that left selectionStart and
+                selectionEnd in an inconsistent state after a form reset.
+            </action>
             <action type="update" dev="rbri">
-                Major refactoring of the value handling for textarea - setting the value no longer manipulates the DOM,
+                Major refactoring of the value handling for textarea; setting the value no longer manipulates the DOM,
                 instead a separate value and dirty flag are maintained (this is now in sync with the spec and the input element).
             </action>
             <action type="remove" dev="rbri">
diff --git a/src/main/java/org/htmlunit/html/HtmlInput.java b/src/main/java/org/htmlunit/html/HtmlInput.java
@@ -68,7 +68,7 @@ public abstract class HtmlInput extends HtmlElement implements DisabledElement,
 
     /**
      * The element's raw value (spec term), decoupled from the DOM child nodes
-     * once {@link #valueDirty_} is {@code true}. Mirrors {@code HtmlInput}'s
+     * once {@link #isValueDirty_} is {@code true}. Mirrors {@code HtmlInput}'s
      * dirty-value-flag model rather than reading/writing child text nodes directly.
      */
     private String rawValue_;
diff --git a/src/main/java/org/htmlunit/html/HtmlSelectableTextInput.java b/src/main/java/org/htmlunit/html/HtmlSelectableTextInput.java
@@ -48,10 +48,11 @@ public abstract class HtmlSelectableTextInput extends HtmlInput implements Selec
      */
     @Override
     public void setValue(final String newValue) {
+        final String oldValue = getValue();
         super.setValue(newValue);
 
         final SgmlPage page = getPage();
-        if (page != null && page.isHtmlPage()) {
+        if (page != null && page.isHtmlPage() && !newValue.equals(oldValue)) {
             final int pos = newValue.length();
             setSelectionStart(pos);
             setSelectionEnd(pos);
@@ -149,16 +150,6 @@ public void setSelectionEnd(final int selectionEnd) {
         selectionDelegate_.setSelectionEnd(selectionEnd);
     }
 
-    /**
-     * {@inheritDoc}
-     * @see HtmlInput#reset()
-     */
-    @Override
-    public void reset() {
-        super.reset();
-        setSelectionEnd(0);
-    }
-
     /**
      * {@inheritDoc}
      */
diff --git a/src/main/java/org/htmlunit/html/HtmlTextArea.java b/src/main/java/org/htmlunit/html/HtmlTextArea.java
@@ -208,11 +208,16 @@ public NameValuePair[] getSubmitNameValuePairs() {
      */
     @Override
     public void reset() {
+        final String oldValue = getText();
+
         isValueDirty_ = false;
 
-        final int pos = computeValueFromChildText().length();
-        setSelectionStart(pos);
-        setSelectionEnd(pos);
+        final String newValue = computeValueFromChildText();
+        if (!newValue.equals(oldValue)) {
+            final int pos = newValue.length();
+            setSelectionStart(pos);
+            setSelectionEnd(pos);
+        }
     }
 
     /**
diff --git a/src/test/java/org/htmlunit/javascript/host/html/HTMLInputElementTest.java b/src/test/java/org/htmlunit/javascript/host/html/HTMLInputElementTest.java
diff --git a/src/test/java/org/htmlunit/javascript/host/html/HTMLTextAreaElementTest.java b/src/test/java/org/htmlunit/javascript/host/html/HTMLTextAreaElementTest.java
