document HtmlButton's no-op implementations for reset and default value handling, and remove extraneous debug logging

rbri · rbri · commit db0800d186d3 · 2026-07-31T12:24:12.000+02:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="5.4.0" date="August xx, 2026" description="Firefox 153, Bugfixes">
+            <action type="remove" dev="rbri">
+                Document HtmlButton's no-op implementations for reset and default value handling, and remove extraneous debug logging.
+            </action>
             <action type="remove" dev="rbri">
                 Method isReadonly() removed from HtmlButton; because there is no readonly support for this control.
             </action>
diff --git a/src/main/java/org/htmlunit/html/HtmlButton.java b/src/main/java/org/htmlunit/html/HtmlButton.java
@@ -19,8 +19,6 @@
 import java.io.IOException;
 import java.util.Map;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
 import org.htmlunit.SgmlPage;
 import org.htmlunit.javascript.host.event.Event;
 import org.htmlunit.javascript.host.event.MouseEvent;
@@ -45,7 +43,7 @@
 public class HtmlButton extends HtmlElement implements DisabledElement, SubmittableElement,
                 LabelableElement, ValidatableElement {
 
-    private static final Log LOG = LogFactory.getLog(HtmlButton.class);
+    // private static final Log LOG = LogFactory.getLog(HtmlButton.class);
 
     /** The HTML tag represented by this element. */
     public static final String TAG_NAME = "button";
@@ -115,31 +113,36 @@ public NameValuePair[] getSubmitNameValuePairs() {
     /**
      * {@inheritDoc}
      *
+     * This implementation is empty; buttons have no reset-specific behavior.
+     *
      * @see SubmittableElement#reset()
      */
     @Override
     public void reset() {
-        LOG.debug("reset() not implemented for this element");
+        // Empty.
     }
 
     /**
      * {@inheritDoc}
      *
+     * This implementation is empty; buttons do not maintain a default value.
+     *
      * @see SubmittableElement#setDefaultValue(String)
      */
     @Override
     public void setDefaultValue(final String defaultValue) {
-        LOG.debug("setDefaultValue() not implemented for this element");
+        // Empty.
     }
 
     /**
      * {@inheritDoc}
      *
+     * This implementation returns an empty string; buttons do not maintain a default value.
+     *
      * @see SubmittableElement#getDefaultValue()
      */
     @Override
     public String getDefaultValue() {
-        LOG.debug("getDefaultValue() not implemented for this element");
         return "";
     }
 
