Skip to content

Intl improvement: Locale, getCanonicalLocales, supportedLocalesOf - #1096

Merged
rbri merged 4 commits into
HtmlUnit:masterfrom
duonglaiquang:duong_intl
Mar 12, 2026
Merged

Intl improvement: Locale, getCanonicalLocales, supportedLocalesOf#1096
rbri merged 4 commits into
HtmlUnit:masterfrom
duonglaiquang:duong_intl

Conversation

@duonglaiquang

Copy link
Copy Markdown
Contributor

This PR does the following

  • Refactor Intl initialization — Move logic from JavaScriptEngine into Intl.init(), making the Intl module self-contained and enabling static function registration (for getCanonicalLocales() in the later commit)

  • Implement Intl.Locale

  • Implement Intl.getCanonicalLocales()

  • Add supportedLocalesOf() to Intl.NumberFormat and Intl.DateTimeFormat

@sonarqubecloud

Copy link
Copy Markdown

@rbri
rbri merged commit cc986a8 into HtmlUnit:master Mar 12, 2026
5 of 8 checks passed
@rbri

rbri commented Mar 12, 2026

Copy link
Copy Markdown
Member

@duonglaiquang this looks great, looking forward to the things you like to do on top of this.

@rbri

rbri commented Mar 13, 2026

Copy link
Copy Markdown
Member

@duonglaiquang looks like my latest cleanup has borken something, working on that

@rbri

rbri commented Mar 13, 2026

Copy link
Copy Markdown
Member

@duonglaiquang have fixed the toString stuff and switched to array-like support. this is a bit closer to the spec. Maybe you like to backport that to your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants