XMLHttpRequest: fix a bug where Access-Control-Allow-Origin: * was not handled correctly - #1098
Merged
Merged
Conversation
duonglaiquang
force-pushed
the
duong_xhr
branch
from
March 12, 2026 09:08
54cbb75 to
4d6f534
Compare
Member
|
@duonglaiquang any chance to have a test for this? |
…not handled correctly
duonglaiquang
force-pushed
the
duong_xhr
branch
from
March 12, 2026 09:30
4d6f534 to
54ac807
Compare
Contributor
Author
|
@rbri i have added a test could you take a look |
|
Member
|
Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following
Addresses CORS preflight handling in HtmlUnit by correcting the
isPreflightAuthorizedmethod inXMLHttpRequestto properly recognize the wildcard*value for theAccess-Control-Allow-Headersresponse header.Problem
When a server responds to a CORS preflight request with
Access-Control-Allow-Headers: *, HtmlUnit does not recognize this as a wildcard. Instead, it treats*as a literal header name and adds it to the set of allowed header names. This causes the preflight authorization check to fail for any non-simple headers, even though the server intended to allow all of them.