Remove redundant modifiers from interfaces.

Author: Quintin Willison

lib/src/main/java/io/ably/lib/http/Http.java

@@ -71,7 +71,7 @@ public void run() {
 	}
 
 	public interface Execute<Result> {
-		public void execute(HttpScheduler http, Callback<Result> callback) throws AblyException;
+		void execute(HttpScheduler http, Callback<Result> callback) throws AblyException;
 	}
 
 	private static class SyncExecuteResult<Result> {

lib/src/main/java/io/ably/lib/realtime/ChannelStateListener.java

@@ -7,12 +7,12 @@
  */
 public interface ChannelStateListener {
 
-	public void onChannelStateChanged(ChannelStateChange stateChange);
+	void onChannelStateChanged(ChannelStateChange stateChange);
 
 	/**
 	 * Channel state change. See Ably Realtime API documentation for more details.
 	 */
-	public class ChannelStateChange {
+	class ChannelStateChange {
 		final public ChannelEvent event;
 		/* (TH2) The ChannelStateChange object contains the current state in
 		 * attribute current, the previous state in attribute previous. */

lib/src/main/java/io/ably/lib/realtime/CompletionListener.java

@@ -12,19 +12,19 @@ public interface CompletionListener {
 	/**
 	 * Called when the associated operation completes successfully,
 	 */
-	public void onSuccess();
+	void onSuccess();
 
 	/**
 	 * Called when the associated operation completes with an error.
 	 * @param reason: information about the error.
 	 */
-	public void onError(ErrorInfo reason);
+	void onError(ErrorInfo reason);
 
 	/**
 	 * A Multicaster instance is used in the Ably library to manage a list
 	 * of client listeners against certain operations.
 	 */
-	public static class Multicaster extends io.ably.lib.util.Multicaster<CompletionListener> implements CompletionListener {
+	class Multicaster extends io.ably.lib.util.Multicaster<CompletionListener> implements CompletionListener {
 		public Multicaster(CompletionListener... members) { super(members); }
 
 		@Override
@@ -44,7 +44,7 @@ public void onError(ErrorInfo reason) {
 		}
 	}
 
-	public static class ToCallback implements Callback<Void> {
+	class ToCallback implements Callback<Void> {
 		private CompletionListener listener;
 		public ToCallback(CompletionListener listener) {
 			this.listener = listener;
@@ -61,7 +61,7 @@ public void onError(ErrorInfo reason) {
 		}
 	}
 
-	public static class FromCallback implements CompletionListener {
+	class FromCallback implements CompletionListener {
 		private final Callback<Void> callback;
 
 		public FromCallback(Callback<Void> callback) {

lib/src/main/java/io/ably/lib/realtime/ConnectionStateListener.java

@@ -4,15 +4,15 @@
 
 public interface ConnectionStateListener {
 
-	public void onConnectionStateChanged(ConnectionStateListener.ConnectionStateChange state);
+	void onConnectionStateChanged(ConnectionStateListener.ConnectionStateChange state);
 
-	public static class ConnectionStateChange {
+	class ConnectionStateChange {
 		public final ConnectionEvent event;
 		public final ConnectionState previous;
 		public final ConnectionState current;
 		public final long retryIn;
 		public final ErrorInfo reason;
-	
+
 		public ConnectionStateChange(ConnectionState previous, ConnectionState current, long retryIn, ErrorInfo reason) {
 			this.event = current.getConnectionEvent();
 			this.previous = previous;
@@ -35,7 +35,7 @@ public static ConnectionStateChange createUpdateEvent(ErrorInfo reason) {
 		}
 	}
 
-	static class Multicaster extends io.ably.lib.util.Multicaster<ConnectionStateListener> implements ConnectionStateListener {
+	class Multicaster extends io.ably.lib.util.Multicaster<ConnectionStateListener> implements ConnectionStateListener {
 		@Override
 		public void onConnectionStateChanged(ConnectionStateChange state) {
 			for(ConnectionStateListener member : members)
@@ -45,7 +45,7 @@ public void onConnectionStateChanged(ConnectionStateChange state) {
 		}
 	}
 
-	static class Filter implements ConnectionStateListener {
+	class Filter implements ConnectionStateListener {
 		@Override
 		public void onConnectionStateChanged(ConnectionStateChange change) {
 			if(change.current == state)
@@ -55,4 +55,4 @@ public void onConnectionStateChanged(ConnectionStateChange change) {
 		ConnectionState state;
 		ConnectionStateListener listener;
 	}
-}
+}

lib/src/main/java/io/ably/lib/rest/Auth.java

@@ -471,7 +471,7 @@ public boolean equals(Object obj) {
 	 * or signed token requests, in response to a request with given token params.
 	 */
 	public interface TokenCallback {
-		public Object getTokenRequest(TokenParams params) throws AblyException;
+		Object getTokenRequest(TokenParams params) throws AblyException;
 	}
 
 	/**

lib/src/main/java/io/ably/lib/transport/ITransport.java

@@ -18,22 +18,22 @@
 
 public interface ITransport {
 
-	public static final String TAG = ITransport.class.getName();
+	String TAG = ITransport.class.getName();
 
-	public interface Factory {
+	interface Factory {
 		/**
 		 * Obtain and instance of this transport based on the specified options.
 		 */
-		public ITransport getTransport(TransportParams transportParams, ConnectionManager connectionManager);
+		ITransport getTransport(TransportParams transportParams, ConnectionManager connectionManager);
 	}
 
-	public enum Mode {
+	enum Mode {
 		clean,
 		resume,
 		recover
 	}
 
-	public static class TransportParams {
+	class TransportParams {
 		protected ClientOptions options;
 		protected String host;
 		protected int port;
@@ -95,36 +95,36 @@ public Param[] getConnectParams(Param[] baseParams) {
 		}
 	}
 
-	public static interface ConnectListener {
-		public void onTransportAvailable(ITransport transport);
-		public void onTransportUnavailable(ITransport transport, ErrorInfo reason);
+	interface ConnectListener {
+		void onTransportAvailable(ITransport transport);
+		void onTransportUnavailable(ITransport transport, ErrorInfo reason);
 	}
 
 	/**
 	 * Initiate a connection attempt; the transport will be activated,
 	 * and attempt to remain connected, until disconnect() is called.
-	 * @throws AblyException 
+	 * @throws AblyException
 	 */
-	public void connect(ConnectListener connectListener);
+	void connect(ConnectListener connectListener);
 
 	/**
 	 * Close this transport.
 	 */
-	public void close();
+	void close();
 
 	/**
 	 * Send a message on the channel
 	 * @param msg
 	 * @throws IOException
 	 */
-	public void send(ProtocolMessage msg) throws AblyException;
+	void send(ProtocolMessage msg) throws AblyException;
 
 	/**
 	 * Get connection URL
 	 * @return
 	 */
-	public String getURL();
+	String getURL();
 
-	public String getHost();
+	String getHost();
 
 }

lib/src/main/java/io/ably/lib/transport/NetworkConnectivity.java

@@ -8,8 +8,8 @@
 public abstract class NetworkConnectivity {
 
 	public interface NetworkConnectivityListener {
-		public void onNetworkAvailable();
-		public void onNetworkUnavailable(ErrorInfo reason);
+		void onNetworkAvailable();
+		void onNetworkUnavailable(ErrorInfo reason);
 	}
 
 	public void addListener(NetworkConnectivityListener listener) {

lib/src/main/java/io/ably/lib/types/AsyncHttpPaginatedResponse.java

@@ -33,12 +33,12 @@ public interface Callback {
 		/**
 		 * Called when the associated request completes with an Http response,
 		 */
-		public void onResponse(AsyncHttpPaginatedResponse response);
+		void onResponse(AsyncHttpPaginatedResponse response);
 
 		/**
 		 * Called when the associated operation completes with an error.
 		 * @param reason: information about the error.
 		 */
-		public void onError(ErrorInfo reason);
+		void onError(ErrorInfo reason);
 	}
 }

lib/src/main/java/io/ably/lib/types/AsyncPaginatedResult.java

@@ -12,16 +12,16 @@ public interface AsyncPaginatedResult<T> {
 	/**
 	 * Get the contents as an array of component type
 	 */
-	public T[] items();
+	T[] items();
 
 	/**
 	 * Obtain params required to perform the given relative query
 	 */
-	public abstract void first(Callback<AsyncPaginatedResult<T>> callback);
-	public abstract void current(Callback<AsyncPaginatedResult<T>> callback);
-	public abstract void next(Callback<AsyncPaginatedResult<T>> callback);
+	void first(Callback<AsyncPaginatedResult<T>> callback);
+	void current(Callback<AsyncPaginatedResult<T>> callback);
+	void next(Callback<AsyncPaginatedResult<T>> callback);
 
-	public abstract boolean hasFirst();
-	public abstract boolean hasCurrent();
-	public abstract boolean hasNext();
+	boolean hasFirst();
+	boolean hasCurrent();
+	boolean hasNext();
 }

lib/src/main/java/io/ably/lib/types/Callback.java

@@ -10,15 +10,15 @@ public interface Callback<T> {
 	/**
 	 * Called when the associated operation completes successfully,
 	 */
-	public void onSuccess(T result);
+	void onSuccess(T result);
 
 	/**
 	 * Called when the associated operation completes with an error.
 	 * @param reason: information about the error.
 	 */
-	public void onError(ErrorInfo reason);
+	void onError(ErrorInfo reason);
 
-	public abstract static class Map<T, U> implements Callback<T> {
+	abstract class Map<T, U> implements Callback<T> {
 		private final Callback<U> callback;
 
 		public abstract U map(T result);