Merge pull request #489 from HubSpot/feature/updateNullableOptions

ksvirkou-hubspot · web-flow · commit 021e0d978a00 · 2025-05-08T11:09:24.000+03:00
Update CRM Owners getAll method
diff --git a/lib/Discovery/Crm/Owners/Discovery.php b/lib/Discovery/Crm/Owners/Discovery.php
@@ -10,13 +10,12 @@
  */
 class Discovery extends DiscoveryBase
 {
-    public function getAll(): array
+    public function getAll(?string $email = null, ?string $after = null, bool $archived = false): array
     {
         $owners = [];
-        $after = null;
 
         do {
-            $page = $this->OwnersApi()->getPage(null, $after, 100);
+            $page = $this->OwnersApi()->getPage($email, $after, 100, $archived);
 
             $owners = array_merge($owners, $page->getResults());
 

Original file line number	Diff line number	Diff line change
`@@ -10,13 +10,12 @@`
`10`	`10`	`*/`
`11`	`11`	`class Discovery extends DiscoveryBase`
`12`	`12`	`{`
`13`		`- public function getAll(): array`
	`13`	`+ public function getAll(?string $email = null, ?string $after = null, bool $archived = false): array`
`14`	`14`	`{`
`15`	`15`	`$owners = [];`
`16`		`- $after = null;`
`17`	`16`
`18`	`17`	`do {`
`19`		`- $page = $this->OwnersApi()->getPage(null, $after, 100);`
	`18`	`+ $page = $this->OwnersApi()->getPage($email, $after, 100, $archived);`
`20`	`19`
`21`	`20`	`$owners = array_merge($owners, $page->getResults());`
`22`	`21`