Skip to content

Commit cec2161

Browse files
Merge pull request #518 from HubSpot/feature/fixWarnings
Fix Implicitly marking parameter as nullable in CRM Objects
2 parents dd70be2 + b706576 commit cec2161

40 files changed

Lines changed: 46 additions & 46 deletions

codegen/Crm/Objects/Api/BasicApi.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ class BasicApi
9595
* @param int $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
9696
*/
9797
public function __construct(
98-
ClientInterface $client = null,
99-
Configuration $config = null,
100-
HeaderSelector $selector = null,
98+
?ClientInterface $client = null,
99+
?Configuration $config = null,
100+
?HeaderSelector $selector = null,
101101
$hostIndex = 0
102102
) {
103103
$this->client = $client ?: new Client();

codegen/Crm/Objects/Api/BatchApi.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ class BatchApi
9595
* @param int $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
9696
*/
9797
public function __construct(
98-
ClientInterface $client = null,
99-
Configuration $config = null,
100-
HeaderSelector $selector = null,
98+
?ClientInterface $client = null,
99+
?Configuration $config = null,
100+
?HeaderSelector $selector = null,
101101
$hostIndex = 0
102102
) {
103103
$this->client = $client ?: new Client();

codegen/Crm/Objects/Api/SearchApi.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ class SearchApi
8383
* @param int $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
8484
*/
8585
public function __construct(
86-
ClientInterface $client = null,
87-
Configuration $config = null,
88-
HeaderSelector $selector = null,
86+
?ClientInterface $client = null,
87+
?Configuration $config = null,
88+
?HeaderSelector $selector = null,
8989
$hostIndex = 0
9090
) {
9191
$this->client = $client ?: new Client();

codegen/Crm/Objects/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ public function getHostSettings()
486486
* @param array|null $variables hash of variable and the corresponding value (optional)
487487
* @return string URL based on host settings
488488
*/
489-
public static function getHostString(array $hostSettings, $hostIndex, array $variables = null)
489+
public static function getHostString(array $hostSettings, $hostIndex, ?array $variables = null)
490490
{
491491
if (null === $variables) {
492492
$variables = [];

codegen/Crm/Objects/Model/AssociatedId.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public function getModelName()
248248
* @param mixed[] $data Associated array of property values
249249
* initializing the model
250250
*/
251-
public function __construct(array $data = null)
251+
public function __construct(?array $data = null)
252252
{
253253
$this->setIfExists('id', $data ?? [], null);
254254
$this->setIfExists('type', $data ?? [], null);

codegen/Crm/Objects/Model/AssociationSpec.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ public function getAssociationCategoryAllowableValues()
265265
* @param mixed[] $data Associated array of property values
266266
* initializing the model
267267
*/
268-
public function __construct(array $data = null)
268+
public function __construct(?array $data = null)
269269
{
270270
$this->setIfExists('association_category', $data ?? [], null);
271271
$this->setIfExists('association_type_id', $data ?? [], null);

codegen/Crm/Objects/Model/BatchInputSimplePublicObjectBatchInput.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ public function getModelName()
242242
* @param mixed[] $data Associated array of property values
243243
* initializing the model
244244
*/
245-
public function __construct(array $data = null)
245+
public function __construct(?array $data = null)
246246
{
247247
$this->setIfExists('inputs', $data ?? [], null);
248248
}

codegen/Crm/Objects/Model/BatchInputSimplePublicObjectBatchInputForCreate.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ public function getModelName()
242242
* @param mixed[] $data Associated array of property values
243243
* initializing the model
244244
*/
245-
public function __construct(array $data = null)
245+
public function __construct(?array $data = null)
246246
{
247247
$this->setIfExists('inputs', $data ?? [], null);
248248
}

codegen/Crm/Objects/Model/BatchInputSimplePublicObjectBatchInputUpsert.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ public function getModelName()
242242
* @param mixed[] $data Associated array of property values
243243
* initializing the model
244244
*/
245-
public function __construct(array $data = null)
245+
public function __construct(?array $data = null)
246246
{
247247
$this->setIfExists('inputs', $data ?? [], null);
248248
}

codegen/Crm/Objects/Model/BatchInputSimplePublicObjectId.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ public function getModelName()
242242
* @param mixed[] $data Associated array of property values
243243
* initializing the model
244244
*/
245-
public function __construct(array $data = null)
245+
public function __construct(?array $data = null)
246246
{
247247
$this->setIfExists('inputs', $data ?? [], null);
248248
}

0 commit comments

Comments
 (0)