Skip to content

Update retry middleware factory#491

Merged
ksvirkou-hubspot merged 1 commit into
feature/13.0.0from
feature/updateRetryMiddlewareFactory
May 12, 2025
Merged

Update retry middleware factory#491
ksvirkou-hubspot merged 1 commit into
feature/13.0.0from
feature/updateRetryMiddlewareFactory

Conversation

@ksvirkou-hubspot
Copy link
Copy Markdown
Collaborator

@ksvirkou-hubspot ksvirkou-hubspot commented May 8, 2025 •
edited
Loading

New RetryMiddleware HTTP Error Codes Handling

  • 504 is removed from the list to allow for a retry in case of server failure.
  • range 520-599 is added in order to allow for new codes like the 525 Cloudflare one.
  • Range 505-511 still considered as an exception without retry.
  • a new function to handle multiple ranges has been added while keeping retro-compatibility
  • Default max retries has been refactored into a class constant

@ksvirkou-hubspot
Copy link
Copy Markdown
Collaborator Author

ksvirkou-hubspot commented May 12, 2025

#432

@ksvirkou-hubspot ksvirkou-hubspot merged commit f1690f3 into feature/13.0.0 May 12, 2025
2 checks passed
@ksvirkou-hubspot ksvirkou-hubspot deleted the feature/updateRetryMiddlewareFactory branch May 12, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alzheltkovskiy-hubspot alzheltkovskiy-hubspot alzheltkovskiy-hubspot approved these changes

@atanasiuk-hubspot atanasiuk-hubspot Awaiting requested review from atanasiuk-hubspot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ksvirkou-hubspot @alzheltkovskiy-hubspot