Improve retry middleware and update documentation#615
Open
ksvirkou-hubspot wants to merge 3 commits into
Open
Conversation
- `getRetryFunctionByConnectionErrors`: swapped param order so `$curlErrorCodes` comes first, consistent with how it is the primary customization point - Passing an empty `$curlErrorCodes` now retries all `ConnectException`s unconditionally, rather than silently skipping them - `getExponentialDelayFunction` deprecated in favour of passing `null` and letting Guzzle apply its built-in exponential backoff - README section renamed from "Rate and Concurrent Limiting" to "Retry Middleware", covering all three middleware, default retry count, available delay helpers, and the empty-array behaviour Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
ksvirkou-hubspot
requested review from
alzheltkovskiy-hubspot and
atanasiuk-hubspot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createConnectionErrorsMiddlewaregetRetryFunctionByConnectionErrors: swapped param order so$curlErrorCodesis first, as it is the primary customization point for this method$curlErrorCodestocreateConnectionErrorsMiddlewarenow retries allConnectExceptions unconditionally instead of silently skipping themDelay::getExponentialDelayFunctiondeprecated — callers should passnulland let Guzzle apply its built-in exponential backoff viaRetryMiddleware::exponentialDelayTest plan
createConnectionErrorsMiddleware()retries on cURL errors 52, 55, 56 (default behaviour unchanged)createConnectionErrorsMiddleware([], ...)retries allConnectExceptionsnulldelay to any middleware uses Guzzle exponential backoff🤖 Generated with Claude Code