Merge pull request #828 from HubSpot/improve-performance-select

Improve performance of selectattr and rejectattr

Author: mattcoley

src/main/java/com/hubspot/jinjava/lib/filter/SelectAttrFilter.java

@@ -111,15 +111,16 @@ protected Object applyFilter(
     }
 
     ForLoop loop = ObjectIterator.getLoop(var);
+    Variable tempVariable = new Variable(
+      interpreter,
+      String.format("%s.%s", "placeholder", attr)
+    );
     while (loop.hasNext()) {
       Object val = loop.next();
 
-      Object attrVal = new Variable(
-        interpreter,
-        String.format("%s.%s", "placeholder", attr)
-      )
-      .resolve(val);
-      if (acceptObjects == expTest.evaluate(attrVal, interpreter, expArgs)) {
+      if (
+        acceptObjects == expTest.evaluate(tempVariable.resolve(val), interpreter, expArgs)
+      ) {
         result.add(val);
       }
     }