Skip to content

fix(404): exclude sitemap-disabled pages from 404 suggestions#3317

Closed
srgg wants to merge 1 commit into
HugoBlox:mainfrom
srgg:fix/404-suggestions-filter
Closed

fix(404): exclude sitemap-disabled pages from 404 suggestions#3317
srgg wants to merge 1 commit into
HugoBlox:mainfrom
srgg:fix/404-suggestions-filter

Conversation

@srgg

@srgg srgg commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Previously, pages with sitemap.disable=true were shown in 404 suggestions. This change filters them out for consistency and better UX.

πŸš€ What type of change is this?

  • πŸ› Bug fix (A non-breaking change that fixes an issue)
  • ✨ New feature (A non-breaking change that adds functionality)
  • πŸ’… Style change (A change that only affects formatting, visuals, or styling)
  • πŸ“š Documentation update (Changes to documentation only)
  • 🧹 Refactor or chore (A code change that neither fixes a bug nor adds a feature)
  • πŸ’₯ Breaking change (A fix or feature that would cause existing functionality to not work as expected)

🎯 What is the purpose of this change?

This change updates the 404 page layout to respect frontmatter flags, such as 1sitemap.disable1, ensuring that hidden or excluded pages do not appear in 404 suggestions. It improves consistency with the sitemap, prevents accidental exposure of private content, and provides a cleaner user experience.

πŸ“Έ Screenshots or Screencast (if applicable)

Not applicable

ℹ️ Documentation Check

  • [ x] No, this change does not require a documentation update.
  • Yes, I have updated the documentation accordingly (or will in a follow-up PR).

πŸ“œ Contributor Agreement

Thank you for your contribution!

Previously, pages with sitemap.disable=true were shown in 404 suggestions.
This change filters them out for consistency and better UX.
@srgg srgg requested a review from gcushen as a code owner April 7, 2026 19:13
@netlify

netlify Bot commented Apr 7, 2026

Copy link
Copy Markdown

βœ… Deploy Preview for academic-demo canceled.

Name Link
πŸ”¨ Latest commit c4e3a60
πŸ” Latest deploy log https://app.netlify.com/projects/academic-demo/deploys/69d55779391b11000878160d

@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Wow, your first PR! Welcome to the community! πŸŽ‰

Thank you for this contribution to open source and open research. It makes a huge impact for the thousands of innovators building with Hugo Blox.

If you're wondering about next steps, please read our Contributor Guide for coding standards, how to run the project locally, and how to get help.

We hope this is just the start of your journey with us. Let's build the future together! Join us on Discord to connect with the team and community.

Awesome work, we'll take a look soon! ✨

@gcushen

gcushen commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PRs and for identifying that private pages can leak into the RSS feed - that's a real gap we'll fix.

However, HugoBlox uses its own private: true frontmatter param (rather than Hugo's newly added sitemap.disable inspired by private) to control page visibility across all surfaces (sitemap, RSS, 404 suggestions, search engine indexing). This is by design - it's a simpler, flatter param that's more intuitive for our audience.

We'll fix the RSS feed to respect private (which was missing). Supporting Hugo's suggested sitemap.disable as an additional mechanism would be a new feature rather than a bug fix, and we'd want to evaluate that separately as that would add unnecessary bloat and confusion for our community.

@gcushen gcushen closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants