Change stt setting panel position#275
Merged
Merged
Conversation
HugoGresse
temporarily deployed
to
GitHub Action PR
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit 18d0124):
(expires Thu, 09 Jul 2026 15:00:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0c15c45ea5a4c54095387eacf30c3755c9260f22 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR repositions the live transcription settings UI from a floating panel to a horizontal strip stacked above the fixed bottom control bar, while also adjusting default settings visibility and improving WhatsApp webhook observability in production.
Changes:
- Reworked
TranscriptionSettingsPanellayout into a responsive horizontal strip intended to sit above the footer controls. - Changed the default
hideSettingsbehavior and madehide_settingsquery parsing fall back to defaults when absent. - Switched WhatsApp webhook logging from
request.logtoconsole.*to ensure logs are emitted when Fastify logging is disabled in production.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/public/transcription/TranscriptionSettingsPanel.tsx | Replaces the floating settings panel with a wrapping horizontal strip layout suitable for a footer stack. |
| src/public/transcription/transcriptionSettings.ts | Updates default hideSettings and refines query-string parsing behavior for settings visibility. |
| src/public/transcription/LiveTranscriptionView.tsx | Stacks the optional settings strip above the fixed bottom talk/control bar. |
| functions/src/api/routes/whatsapp/whatsapp.ts | Uses console.* logging for webhook handling to ensure production logs reach Cloud Logging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+126
to
+130
| label="Endpointing (s)" | ||
| inputProps={{ step: 0.05, min: 0 }} | ||
| value={settings.endpointing} | ||
| onChange={(e) => set('endpointing', Number(e.target.value) || settings.endpointing)} | ||
| sx={fieldSx} |
Comment on lines
70
to
+73
| languages: languages?.length ? languages : DEFAULT_SETTINGS.languages, | ||
| customVocabulary: csv(q.get('custom_vocabulary')) ?? DEFAULT_SETTINGS.customVocabulary, | ||
| endpointing: num('endpointing', DEFAULT_SETTINGS.endpointing), | ||
| hideSettings: q.get('hide_settings') === 'true', | ||
| hideSettings: q.has('hide_settings') ? q.get('hide_settings') === 'true' : DEFAULT_SETTINGS.hideSettings, |
Comment on lines
+380
to
+384
| // Use console.* (not request.log): the Fastify logger is disabled in production, so | ||
| // request.log is a no-op there and nothing reaches Cloud Logging. console.* is captured. | ||
| console.info('[whatsapp webhook] received', { | ||
| eventId, | ||
| typeWebhook: body?.typeWebhook, |
HugoGresse
added a commit
that referenced
this pull request
Jul 2, 2026
Address Copilot review on #275: - endpointing settings field & URL param now accept 0 (disable endpointing); previously the falsy `|| fallback` and the num() `> 0` guard made 0 impossible to set. - move GO-reminder scheduling error from request.log to console.* so it reaches Cloud Logging in production (Fastify logger is disabled outside dev/test). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
HugoGresse
added a commit
that referenced
this pull request
Jul 2, 2026
* Move to next talk on the STT automatically * fix(transcription): allow endpointing 0 + prod webhook logging Address Copilot review on #275: - endpointing settings field & URL param now accept 0 (disable endpointing); previously the falsy `|| fallback` and the num() `> 0` guard made 0 impossible to set. - move GO-reminder scheduling error from request.log to console.* so it reaches Cloud Logging in production (Fastify logger is disabled outside dev/test). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(transcription): avoid double auto-advance under StrictMode Address Copilot review on #276: calling onAdvance() synchronously for an already-ended talk fired twice under React 18 StrictMode, skipping a talk. Always schedule via setTimeout (clamped to 0) with a cleanup so the remount cleanup cancels the first invocation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.