fix(evlog): support primitive values in defineEnricher#320
Merged
HugoRCD merged 1 commit intoHugoRCD:mainfrom May 5, 2026
Merged
fix(evlog): support primitive values in defineEnricher#320HugoRCD merged 1 commit intoHugoRCD:mainfrom
HugoRCD merged 1 commit intoHugoRCD:mainfrom
Conversation
|
@payton-burr is attempting to deploy a commit to the HRCD Projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
The docs show
defineEnricher<string>as a supported pattern for custom enrichers, but the current implementation only accepts object types:EnricherDefinition<T extends object>anddefineEnricher<T extends object>prevent primitive type parameters at the type level.mergeEventField<T extends object>was written around object spreading and didn't cleanly handle primitive computed values.This change aligns the implementation with the documented behavior:
T extends objectconstraint onEnricherDefinition,defineEnricher, andmergeEventField.mergeEventFieldto handle primitives; object-merge semantics are unchanged.📝 Checklist