fix(app): align welcomeEmail props with EmailService#729
Merged
Conversation
The template declared a required name prop but the service has always sent username + redirectUrl, producing a Vue warning every time a welcome email was rendered. Renamed the prop to username and added redirectUrl, then used redirectUrl on the CTA button (it was hardcoded to https://app.shelve.cloud, ignoring the value the caller passed in).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
HugoRCD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The welcome email template declared
name: requiredbutEmailService.generateWelcomeTemplatehas always sentusername+redirectUrl, which produced a[Vue warn]: Missing required prop: \"name\"every time a user signed up.nametousernameand addedredirectUrl.redirectUrlinto the CTA button (it was hardcoded tohttps://app.shelve.cloud, ignoring whatever the caller passed in).Pre-existing bug, no behavior change beyond removing the warning and honoring
redirectUrl.Test plan
[Vue warn]: Missing required propfromWelcomeEmail.