test(cli): cover offline cache, credentials, secret refs, ignore files#734
Merged
Conversation
Adds 47 new vitest cases exercising the v5 additions to the CLI: - CacheService: AES-256-GCM roundtrip, TTL expiry, token rotation and tamper detection, stable cache keys across URL trailing slashes. - CredentialsService: XDG file fallback (keychain mocked out), token read/write/clear, legacy `~/.shelve` migration with deletion, no-op when the XDG file already has data. - `writeAgentIgnoreFiles`: idempotent writes, preservation of pre-existing user content, upsert of the shelve-managed block. - `parseEnvTemplate` / `resolveReferences`: literals, short-form and scoped `shelve://` references, rename-on-resolve, reporting of cross-env and missing references. - `parseDuration`: unit parsing (ms/s/m/h/d), decimals, case and whitespace tolerance, fallback on garbage input. Along the way `CredentialsService.writeToken` now mkdirs `$XDG_CONFIG_HOME` on first write so freshly provisioned machines no longer fail with ENOENT when rc9 hands off to `writeFileSync`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.shelvemigration,shelve://secret references, agent-ignore files, andparseDuration.CredentialsService.writeTokenwhere freshly provisioned machines (no~/.config) would fail withENOENTbefore ever writing the token — the config directory is now created on demand.Test plan
PR order
This is PR 1/4 in the v5 follow-up series. It is independent and can land in any order relative to the other three.