fix(changeset): retarget LP changesets to @shelve/lp#740
Merged
Conversation
Two changesets still referenced the old "shelve" package name (it was renamed to @shelve/app + @shelve/lp during the v5 split), which made @changesets/assemble-release-plan throw "Found changeset X for package shelve which is not in the workspace" and broke the release workflow. Both changesets are about landing-page / docs work, so they belong to @shelve/lp.
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow has been failing on every push to `main` since v5 with:
```
🦋 error Found changeset lp-v5-features for package shelve which is not in the workspace
```
Two changesets (`lp-v5-features.md` and `quiet-lizards-give.md`) still target a package literally named `"shelve"`, which doesn't exist anymore — during the v5 split the app was renamed `@shelve/app` and the landing page `@shelve/lp`. `@changesets/assemble-release-plan` errors out before it can build a release plan, so changeset PR creation never runs.
Both changesets are about landing-page content / docs, so they belong to `@shelve/lp`.
Verified locally: `pnpm exec changeset status` and `pnpm run version` both get past assemble-release-plan after the fix (the only remaining local error is a missing `GITHUB_TOKEN` for changelog generation, which is provided in CI).
Test plan