chore(changeset): drop no-op LP changesets#742
Merged
Conversation
@shelve/lp is content-only and has no `version` field in its
package.json, so Changesets can't bump it. The two changesets that
targeted it were therefore no-ops: `changeset version` produced an
empty diff, which made the release action fail when it tried to push
`changeset-release/main` and open a PR ("No commits between main and
changeset-release/main").
Their content already shipped via #737 (docs) and #738 (LP), so just
delete them. Once Changesets gains a real bump again the workflow
will be unblocked.
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #740. The release workflow still fails after that fix, this time on PR creation:
```
Error: HttpError: Validation Failed: ... "No commits between main and changeset-release/main"
```
Root cause
`@shelve/lp` is content-only and has no `version` field in its `package.json` — Changesets silently skips it. The two remaining changesets (`lp-v5-features.md`, `quiet-lizards-give.md`) were the only ones left after #741 consumed `token-ui-restrictions`, and both targeted `@shelve/lp`. Result:
Fix
Just delete the two no-op changesets. Their content already shipped via #737 (docs) and #738 (LP). Once a real bump shows up again the workflow will be unblocked.
Verified locally
```
$ pnpm exec changeset status
🦋 info NO packages to be bumped at patch
🦋 info NO packages to be bumped at minor
🦋 info NO packages to be bumped at major
```
So after merge the release action will simply have nothing to do (the changesets/action step exits without trying to push), which is the correct steady state.
Followup
Worth considering longer-term: drop the LP from changeset's awareness entirely (either give it a `version` so it can actually be bumped, or add it to the `ignore` list in `.changeset/config.json`) so we don't fall in this trap again. Happy to do it in a follow-up.
Test plan