Skip to content

fix(cli): credentials written in the wrong path#745

Merged
HugoRCD merged 1 commit into
mainfrom
cli/fix-login
May 30, 2026
Merged

fix(cli): credentials written in the wrong path#745
HugoRCD merged 1 commit into
mainfrom
cli/fix-login

Conversation

@HugoRCD
Copy link
Copy Markdown
Owner

@HugoRCD HugoRCD commented May 30, 2026

🔗 Linked issue

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed shelve -v command to display the project version instead of the CLI version
    • Fixed shelve login command to store credentials in the correct location for the CLI to access

Review Change Stack

@HugoRCD HugoRCD self-assigned this May 30, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

Deployment failed with the following error:

There is no GitHub account connected to this Vercel account.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
shelve-app Building Building Preview, Comment, Open in v0 May 30, 2026 3:59pm

@github-actions github-actions Bot added the bug Something isn't working label May 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 30, 2026

Thank you for following the naming conventions! 🙏

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 00e187e5-e18b-4abc-a34b-c3197a8bbe65

📥 Commits

Reviewing files that changed from the base of the PR and between 30aa597 and 22ddc1b.

📒 Files selected for processing (3)
  • .changeset/jolly-turtles-allow.md
  • packages/cli/src/index.ts
  • packages/cli/src/services/base.ts

📝 Walkthrough

Walkthrough

This PR bundles two independent CLI fixes into a patch release. The CLI now reports its own version at runtime from the local package.json instead of asynchronously loading it, and credential storage during login now persists tokens through CredentialsService instead of directly calling a legacy writer.

Changes

Patch Release Fixes

Layer / File(s) Summary
CLI version reporting from local package.json
.changeset/jolly-turtles-allow.md, packages/cli/src/index.ts
New getCliPackageVersion() reads the CLI package version from ../package.json at runtime with 'unknown' fallback, and main.meta.version is wired to this getter. Changeset documents this fix and the credential storage fix together.
Token persistence via CredentialsService
packages/cli/src/services/base.ts
BaseService.getToken now calls CredentialsService.writeToken() instead of writeUser() to persist retrieved tokens, with imports updated accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cli/fix-login

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HugoRCD HugoRCD merged commit 8e6b0ee into main May 30, 2026
10 of 14 checks passed
@HugoRCD HugoRCD deleted the cli/fix-login branch May 30, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant