Skip to content

Commit c4c2655

Browse files
committed
Fix a bug when registering a validation test result started by a user who is not already in the KG
1 parent 370c572 commit c4c2655

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

.gitlab-ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ run_tests:
1212
script:
1313
- cd validation_service_api
1414
- pip install --no-cache-dir -r requirements.txt.lock
15+
- pip install pytest
1516
- pytest validation_service/tests
1617
tags:
1718
- docker-runner

validation_service_api/validation_service/resources/results.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@ def _save_result(validation_activity, kg_client):
290290
validation_activity.custom_property_sets.data_location.save(
291291
kg_client, recursive=True, activity_log=activity_log, space=validation_activity.space
292292
)
293+
if validation_activity.started_by.id is None:
294+
validation_activity.started_by.save(kg_client, recursive=False, activity_log=activity_log, space=validation_activity.space)
293295
logger.warning(f"Saving ModelValidation object ({datetime.now().isoformat()})")
294296
validation_activity.save(kg_client, recursive=False, activity_log=activity_log, space=validation_activity.space)
295297
logger.warning(f"Background task complete: results saved for model validation {validation_activity.uuid}")

validation_service_api/validation_service/tests/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)