fix: Windows path backslash issue in COCO to LabelStudio path conversion

GitOrigin-RevId: d94a90f9ac137e147b28ee56198e69c4627b5099

Author: robot-ci-heartex

src/label_studio_sdk/converter/imports/coco.py

@@ -1,10 +1,9 @@
-import os
 import json  # better to use "imports ujson as json" for the best performance
 import uuid
 import logging
 from PIL import Image
 
-from label_studio_sdk.converter.utils import ExpandFullPath
+from label_studio_sdk.converter.utils import ExpandFullPath, join_input_url
 from label_studio_sdk.converter.imports.label_config import generate_label_config
 
 logger = logging.getLogger("root")
@@ -22,7 +21,7 @@ def new_task(out_type, root_url, file_name):
         dict: Label Studio task structure with image data and empty result array
     """
     return {
-        "data": {"image": os.path.join(root_url, file_name)},
+        "data": {"image": join_input_url(root_url, file_name)},
         # 'annotations' or 'predictions'
         out_type: [
             {

src/label_studio_sdk/converter/imports/pathtrack.py

@@ -10,6 +10,8 @@
 
 from types import SimpleNamespace
 
+from label_studio_sdk.converter.utils import join_input_url
+
 logger = logging.getLogger()
 logger.setLevel(logging.DEBUG)
 
@@ -214,15 +216,12 @@ def convert_dataset(
     logger.info("Convert dataset start: %s", root_dir)
     tasks = []
 
-    if not root_url.endswith("/"):
-        root_url += "/"
-
     for d in os.listdir(root_dir):
         shot_dir = os.path.join(root_dir, d)
         if not os.path.isdir(shot_dir):
             continue
 
-        input_url = root_url + d + "/video.mp4"
+        input_url = join_input_url(root_url, d, "video.mp4")
         label_file = os.path.join(shot_dir, "gt/gt.txt")
         info_file = os.path.join(shot_dir, "info.xml")
 

src/label_studio_sdk/converter/imports/yolo.py

@@ -6,11 +6,8 @@
 
 from PIL import Image
 from typing import Optional, Tuple
-from urllib.request import (
-    pathname2url,
-)  # for converting "+","*", etc. in file paths to appropriate urls
 
-from label_studio_sdk.converter.utils import ExpandFullPath
+from label_studio_sdk.converter.utils import ExpandFullPath, join_input_url
 from label_studio_sdk.converter.imports.label_config import generate_label_config
 
 logger = logging.getLogger("root")
@@ -79,12 +76,9 @@ def convert_yolo_to_ls(
         if not image_file_found_flag:
             continue
 
-        image_root_url += "" if image_root_url.endswith("/") else "/"
         task = {
             "data": {
-                # eg. '../../foo+you.py' -> '../../foo%2Byou.py'
-                "image": image_root_url
-                + str(pathname2url(image_file))
+                "image": join_input_url(image_root_url, image_file)
             }
         }
 

src/label_studio_sdk/converter/utils.py

@@ -8,11 +8,12 @@
 import re
 import shutil
 import urllib
+import posixpath
 import wave
 from collections import defaultdict
 from copy import deepcopy
 from operator import itemgetter
-from urllib.parse import urlparse
+from urllib.parse import parse_qsl, quote, urlencode, urlparse, urlsplit, urlunsplit
 
 import numpy as np
 import requests
@@ -134,6 +135,55 @@ def _get_upload_dir(project_dir=None, upload_dir=None):
     return upload_dir
 
 
+def join_input_url(root_url: str, *file_parts: str) -> str:
+    """Join a root URL/prefix and file name in a platform-independent way.
+
+    The converter supports both regular URL prefixes (http/s3/relative paths)
+    and Label Studio local-files URLs with the ``?d=`` query parameter.
+    """
+    if not isinstance(root_url, str) or not root_url.strip():
+        raise ValueError("root_url must be a non-empty string")
+
+    normalized_parts = []
+    for part in file_parts:
+        if part is None:
+            continue
+        if not isinstance(part, str):
+            raise TypeError("All file path parts must be strings")
+
+        normalized_part = part.replace("\\", "/").strip("/")
+        if not normalized_part:
+            continue
+        normalized_parts.append(normalized_part)
+
+    if not normalized_parts:
+        raise ValueError("At least one file path part must be provided")
+
+    relative_path = posixpath.join(*normalized_parts).lstrip("/")
+    parsed = urlsplit(root_url)
+    query_items = parse_qsl(parsed.query, keep_blank_values=True)
+
+    is_local_files_url = parsed.path.rstrip("/").endswith("/data/local-files") and any(
+        key == "d" for key, _ in query_items
+    )
+    if is_local_files_url:
+        updated_query_items = []
+        for key, value in query_items:
+            if key == "d":
+                value = f"{value.rstrip('/')}/{relative_path}" if value else relative_path
+            updated_query_items.append((key, value))
+        encoded_query = urlencode(updated_query_items, doseq=True, quote_via=quote, safe="/")
+        return urlunsplit((parsed.scheme, parsed.netloc, parsed.path, encoded_query, parsed.fragment))
+
+    encoded_path = quote(relative_path, safe="/")
+    if parsed.scheme or parsed.netloc:
+        path_prefix = parsed.path.rstrip("/")
+        joined_path = posixpath.join(path_prefix, encoded_path) if path_prefix else f"/{encoded_path}"
+        return urlunsplit((parsed.scheme, parsed.netloc, joined_path, parsed.query, parsed.fragment))
+
+    return f"{root_url.rstrip('/')}/{encoded_path}"
+
+
 def download(
     url,
     output_dir,

tests/custom/converter/test_import_url_join.py

@@ -0,0 +1,43 @@
+import pytest
+
+from label_studio_sdk.converter.utils import join_input_url
+
+
+def test_join_input_url_local_files_root_with_windows_style_path_from_issue():
+    result = join_input_url("/data/local-files/?d=", r"images\test.jpg")
+
+    assert result == "/data/local-files/?d=images/test.jpg"
+
+
+def test_join_input_url_local_files_root_with_existing_prefix_and_spaces():
+    result = join_input_url("/data/local-files/?d=val2017", "sub dir/image 1.jpg")
+
+    assert result == "/data/local-files/?d=val2017/sub%20dir/image%201.jpg"
+
+
+def test_join_input_url_http_root_encodes_url_path():
+    result = join_input_url("https://example.com/images", "sub dir/image 1.jpg")
+
+    assert result == "https://example.com/images/sub%20dir/image%201.jpg"
+
+
+def test_join_input_url_s3_root_keeps_prefix_and_slashes():
+    result = join_input_url("s3://bucket/coco/val2017/", "nested/image.jpg")
+
+    assert result == "s3://bucket/coco/val2017/nested/image.jpg"
+
+
+def test_join_input_url_local_files_root_with_multiple_parts():
+    result = join_input_url("/data/local-files/?d=", "images\\nested", "test.jpg")
+
+    assert result == "/data/local-files/?d=images/nested/test.jpg"
+
+
+def test_join_input_url_rejects_empty_root_url():
+    with pytest.raises(ValueError, match="root_url must be a non-empty string"):
+        join_input_url("", "image.jpg")
+
+
+def test_join_input_url_rejects_empty_path_parts_after_normalization():
+    with pytest.raises(ValueError, match="At least one file path part must be provided"):
+        join_input_url("/data/local-files/?d=", "", "/", None)