Skip to content

Commit a30f8da

Browse files
authored
fix: use memoryStrategyId instead of strategyId in search_long_term_memories (aws#314)
The boto3 retrieve_memory_records API requires memoryStrategyId in searchCriteria, but MemorySessionManager was sending strategyId, causing a parameter validation error. Fixes aws#303
1 parent 4730894 commit a30f8da

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/bedrock_agentcore/memory/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,7 @@ def search_long_term_memories(
905905
logger.info(" -> Querying long-term memory in namespace '%s' with query: '%s'...", namespace_prefix, query)
906906
search_criteria = {"searchQuery": query, "topK": top_k}
907907
if strategy_id:
908-
search_criteria["strategyId"] = strategy_id
908+
search_criteria["memoryStrategyId"] = strategy_id
909909

910910
namespace = namespace_prefix
911911
params = {

tests/bedrock_agentcore/memory/test_session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1213,7 +1213,7 @@ def test_search_long_term_memories_with_strategy(self):
12131213

12141214
# Verify strategy_id was passed
12151215
call_args = mock_client_instance.retrieve_memory_records.call_args[1]
1216-
assert call_args["searchCriteria"]["strategyId"] == "strategy-123"
1216+
assert call_args["searchCriteria"]["memoryStrategyId"] == "strategy-123"
12171217

12181218
def test_search_long_term_memories_client_error(self):
12191219
"""Test search_long_term_memories with ClientError."""
@@ -2182,7 +2182,7 @@ def test_search_long_term_memories_without_strategy_id(self):
21822182

21832183
# Verify strategy_id was not passed
21842184
call_args = mock_client_instance.retrieve_memory_records.call_args[1]
2185-
assert "strategyId" not in call_args["searchCriteria"]
2185+
assert "memoryStrategyId" not in call_args["searchCriteria"]
21862186

21872187
def test_list_long_term_memory_records_without_strategy_id(self):
21882188
"""Test list_long_term_memory_records without strategy_id to cover missing branch."""

0 commit comments

Comments
 (0)