feat: split release workflow into prepare and publish#1
Merged
Conversation
Hweinstock
pushed a commit
that referenced
this pull request
Mar 11, 2026
…aws#290) Bug #1 from issue aws#212: The _wrap_configuration method was crashing with ValueError when trying to modify CUSTOM strategies with SELF_MANAGED configuration type. Root cause: The code attempted to convert override_type string to OverrideType enum without handling the case where override_type is not a valid enum value (e.g., 'SELF_MANAGED' which is a valid configuration type but not in the OverrideType enum). Fix: Add _try_get_override_type() helper method that safely converts override_type to OverrideType enum, returning None for invalid values. Update _wrap_configuration to use this helper and fall through to pass-through behavior when override_enum is None or not in the wrapper key dictionaries. This allows CUSTOM strategies with SELF_MANAGED configuration to be modified without crashing, with their configuration passed through as-is (no special wrapping). Fixes aws#212 (Bug #1) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of splitting release workflow, merging into fork main for testing.