Support heif/heic and other image thumbnails in dolphin.#1470
Conversation
|
This should be in extra for now. Don't worry we will have separate meta files for each configs and dependencies. |
1 similar comment
|
This should be in extra for now. Don't worry we will have separate meta files for each configs and dependencies. |
|
@JunaidQrysh changelog please |
|
@kRHYME7 you fine with it being in pkg_core? |
|
Please move it in extra |
|
Changlog please |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
📝 WalkthroughWalkthroughA single entry for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Scripts/pkg_extra.lst`:
- Line 18: Add a user-visible changelog entry for the new package
"kimageformats" before merging: update the project's changelog with a short
entry mentioning the addition of kimageformats (support for heif/heic and other
image formats for Qt-based apps), include the PR number/author and a brief note
about user impact (thumbnails and image format support), and place it in the
Unreleased or appropriate section so maintainers can review it alongside the
package addition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 67cc767e-63c8-4f83-a915-aa0830d4eb13
📒 Files selected for processing (1)
Scripts/pkg_extra.lst
This is an automated PR to promote changes from `dev` to `rc`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged during: **Freeze Week (see release policy)** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * fix issues on fresh install (16e2897) by kRHYME7 * chore try to fix errors on fresh install (5aff210) by kRHYME7 * chore cleanup (92ed1f4) by kRHYME7 * chore See Changelog (8d34ef9) by kRHYME7 * chore Merge branch 'rc' into dev (0b3559d) by Khing * chore Merge branch 'rc' into dev (06f6f11) by Khing * fix: Fix hyprquery package install hangs restore (#1706) (265937d) by Khing * fix: Fix hyprquery package install hangs restore (364bc93) by PureFallen * feat: Update `rofi.websearch` and `websearch.lst` to concatenate query url and query string dynamically (#1703) (e42e77b) by Khing * chore refactor: use `printf` instead of `echo` in rofi.websearch.sh (a18f9c7) by l-bloodstone * chore update: remove duplicate entry from websearch.lst (1b1a5d2) by l-bloodstone * chore refactor: rofi.websearch.sh to use url encoded query string (1965253) by l-bloodstone * chore update!: rofi.websearch.sh in order to make query URL dynamic (c2ce11d) by l-bloodstone * chore Merge branch 'HyDE-Project:dev' into dev (1047f2f) by l-bloodstone * chore update!: websearch.lst for new query url syntax (ecbf690) by l-bloodstone * chore Support heif/heic and other image thumbnails in dolphin. (#1470) (29dfac6) by Khing * chore Merge branch 'dev' into patch-1 (c06308f) by Khing * feat: waybar app launcher module (#1557) (8927f07) by Khing * chore Merge branch 'dev' into waybar-app-launcher (705fb43) by Khing * chore Windowrules blender (#1698) (7b3a8eb) by Khing * chore Merge branch 'dev' into windowrules_blender (07db31c) by Khing * chore Merge branch 'rc' into dev (641e88a) by Khing * chore chores: add precommit (#1694) (2d1f562) by Khing * chore Merge branch 'dev' into precommit (0851430) by Khing * chore Added experimental lua support in our scripts. (b0bcf58) by kRHYME7 * chore Merge branch 'dev' into windowrules_blender (1a199fc) by Khing * chore Merge branch 'dev' into precommit (7c1d73f) by Khing * chore Merge upstream/dev into windowrules_blender (835517a) by Kminek42 * feat: add floating rules for Blender Render window (01d9a05) by Kminek42 * feat: add opacity rule for blender to disable transparency (d4b181a) by Kminek42 * chore Update CONTRIBUTING.md (8c4ee77) by Rubin Bhandari * chore Update CONTRIBUTING.md (1437b21) by Rubin Bhandari * chore Merge branch 'dev' into precommit (d15dc20) by Rubin Bhandari * chore chores: add precommit (bd0c6b2) by Rubin Bhandari * chore Merge branch 'dev' into waybar-app-launcher (5955c7f) by Khing * chore Merge branch 'dev' into patch-1 (f17cd4c) by Khing * fix: dont use `shift` in default case (7032544) by Ilya Bogdanov * feat: rename waybar module `custom/applauncher` -> `custom/app-launcher` (3208d23) by Ilya Bogdanov * fix: add quotes as suggested by @coderabbitai (69e069e) by Ilya Bogdanov * feat: new `applauncher` module for waybar (58322e7) by Ilya Bogdanov * fix: change border to one prop (4a3b428) by Ilya Bogdanov * chore Merge branch 'dev' into patch-1 (51ef10b) by Khing * chore Merge branch 'dev' into patch-1 (039d3ed) by Khing * chore Merge branch 'dev' into patch-1 (1eb5776) by Khing * chore Merge branch 'dev' into patch-1 (13b33fb) by Khing * chore move kimageformats to pkg_extra (3bb632e) by JunaidQrysh * chore Merge branch 'dev' into patch-1 (efc8af6) by Khing * chore Merge branch 'dev' into patch-1 (0819935) by Khing --- Please review the changes carefully before merging.
This is an automated PR to promote changes from `rc` to `master`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged on: **1st or 3rd Friday of the month** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * chore Update CHANGELOG for v26.4.5 release (3d9d1d8) by Khing * chore chore: Release - dev → rc (#1718) (a42707c) by Khing * chore Merge branch 'rc' into dev (44976b1) by Khing * fix: Deprecate dontkillsteam (#1710) (7295838) by Shiba * chore chore: Release - dev → rc (#1702) (05bfe84) by Khing * fix issues on fresh install (16e2897) by kRHYME7 * chore Merge branch 'master' into rc (645f15c) by Khing * chore try to fix errors on fresh install (5aff210) by kRHYME7 * chore cleanup (92ed1f4) by kRHYME7 * chore See Changelog (8d34ef9) by kRHYME7 * chore Merge branch 'rc' into dev (0b3559d) by Khing * chore Merge branch 'master' into rc (663789f) by Khing * chore Merge branch 'rc' into dev (06f6f11) by Khing * chore Merge branch 'master' into rc (7fd0274) by Khing * fix: Fix hyprquery package install hangs restore (#1706) (265937d) by Khing * fix: Fix hyprquery package install hangs restore (364bc93) by PureFallen * chore pr (1a06650) by Khing * feat: Update `rofi.websearch` and `websearch.lst` to concatenate query url and query string dynamically (#1703) (e42e77b) by Khing * chore refactor: use `printf` instead of `echo` in rofi.websearch.sh (a18f9c7) by l-bloodstone * chore update: remove duplicate entry from websearch.lst (1b1a5d2) by l-bloodstone * chore refactor: rofi.websearch.sh to use url encoded query string (1965253) by l-bloodstone * chore update!: rofi.websearch.sh in order to make query URL dynamic (c2ce11d) by l-bloodstone * chore Merge branch 'HyDE-Project:dev' into dev (1047f2f) by l-bloodstone * chore update!: websearch.lst for new query url syntax (ecbf690) by l-bloodstone * chore Support heif/heic and other image thumbnails in dolphin. (#1470) (29dfac6) by Khing * chore Merge branch 'dev' into patch-1 (c06308f) by Khing * feat: waybar app launcher module (#1557) (8927f07) by Khing * chore Merge branch 'dev' into waybar-app-launcher (705fb43) by Khing * chore Windowrules blender (#1698) (7b3a8eb) by Khing * chore Merge branch 'dev' into windowrules_blender (07db31c) by Khing * chore Merge branch 'rc' into dev (641e88a) by Khing * chore chores: add precommit (#1694) (2d1f562) by Khing * chore Merge branch 'dev' into precommit (0851430) by Khing * chore Added experimental lua support in our scripts. (b0bcf58) by kRHYME7 * chore Merge branch 'dev' into windowrules_blender (1a199fc) by Khing * chore Merge branch 'dev' into precommit (7c1d73f) by Khing * chore Merge upstream/dev into windowrules_blender (835517a) by Kminek42 * feat: add floating rules for Blender Render window (01d9a05) by Kminek42 * feat: add opacity rule for blender to disable transparency (d4b181a) by Kminek42 * chore Update CONTRIBUTING.md (8c4ee77) by Rubin Bhandari * chore Update CONTRIBUTING.md (1437b21) by Rubin Bhandari * chore Merge branch 'dev' into precommit (d15dc20) by Rubin Bhandari * chore chores: add precommit (bd0c6b2) by Rubin Bhandari * chore Merge branch 'dev' into waybar-app-launcher (5955c7f) by Khing * chore Merge branch 'dev' into patch-1 (f17cd4c) by Khing * fix: dont use `shift` in default case (7032544) by Ilya Bogdanov * feat: rename waybar module `custom/applauncher` -> `custom/app-launcher` (3208d23) by Ilya Bogdanov * fix: add quotes as suggested by @coderabbitai (69e069e) by Ilya Bogdanov * feat: new `applauncher` module for waybar (58322e7) by Ilya Bogdanov * fix: change border to one prop (4a3b428) by Ilya Bogdanov * chore Merge branch 'dev' into patch-1 (51ef10b) by Khing * chore Merge branch 'dev' into patch-1 (039d3ed) by Khing * chore Merge branch 'dev' into patch-1 (1eb5776) by Khing * chore Merge branch 'dev' into patch-1 (13b33fb) by Khing * chore move kimageformats to pkg_extra (3bb632e) by JunaidQrysh * chore Merge branch 'dev' into patch-1 (efc8af6) by Khing * chore Merge branch 'dev' into patch-1 (0819935) by Khing --- Please review the changes carefully before merging.
Pull Request
Description
I spent some time trying to figure out why heic thumbnails were not working in dolphin and since most phones's
default image format is heic I think its better someone else does not go through the same hassle as me.
Type of change
Please put an
xin the boxes that apply:Checklist
Please put an
xin the boxes that apply:Summary by CodeRabbit