Conversation
Added support for passing extra args to rofi. The idea was to use `-click-to-exit` option to be able to control app menu without keyboard fully. But at the moment `-click-to-exit` is unsupported on wayland davatorium/rofi#2158
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Pull Request Adds precommit basic config for making the code base implement a standard https://pre-commit.com ## Description Please read these instructions and remove unnecessary text. - Try to include a summary of the changes and which issue is fixed. - Also include relevant motivation and context (if applicable). - Make sure to make PR against dev and not the master - List any dependencies that are required for this change. (e.g., packages or other PRs) - Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue) - Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable) ## Type of change Please put an `x` in the boxes that apply: - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [x] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [x] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [ ] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Screenshots (if appropriate) ## Additional context Add any other context about the problem here. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added pre-commit hooks to automatically validate file formats (JSON, YAML, TOML, XML), enforce file hygiene (newline at EOF, trailing whitespace), detect merge conflicts/large files/symlinks, and lint Markdown. * Updated contribution guidelines to require running pre-commit checks before completing the pull request creation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
# Pull Request ## Description This PR adds window rules for Blender to improve user experience: - Added opacity rule to disable transparency for Blender windows (opacity 100%) - Added floating rules for the Blender Render window (initial_title "Image Editor") - Added size rule to set Blender Render to 50% of monitor size **Reasoning:** 1. **Opacity**: Blender is graphic/3D software where transparency completely distorts colors, which is unacceptable for color-critical work. Even slight transparency can cause visual artifacts when viewing renders. 2. **Floating**: Without floating, opening the Blender Render window causes the main Blender window to resize, which triggers the viewport to re-render. This is disruptive during render review. These changes allow the Blender Render window to float with a reasonable size while keeping the main Blender window tiled with full opacity. ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Screenshots <img width="2560" height="1440" alt="image" src="https://github.com/user-attachments/assets/af0b94b6-527b-44e7-a095-1f48d362be1f" /> <img width="2560" height="1440" alt="image" src="https://github.com/user-attachments/assets/f9f55c0f-eeec-4938-a76c-93674a8fc84b" /> ## Additional context - Related to Hyprland windowrules configuration - Class name for Blender is `blender` - Blender Render window has `initial_title` = "Image Editor" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added window manager rules for Blender so render and image editor windows open fully opaque, float automatically, and use a preset half-screen size for improved visibility and positioning. * **Documentation** * Changelog updated to document the new Blender window management behavior and the associated UI adjustments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
# Pull Request ## Description ### Feature This PR is relateted to #1551 Adds simple waybar module which opens rofi apps menu with a click <img width="153" height="147" alt="image" src="https://github.com/user-attachments/assets/1010e278-fe1b-4545-a219-08900214496f" /> Also added support for passing extra args to rofi via `hyde-shell rofilaunch`. The idea was to use `-click-to-exit` option to be able to control rofi menu without keyboard fully. But at the moment `-click-to-exit` is unsupported on wayland davatorium/rofi#2158 ### Fixes Change styles for tooltip & menu decoration because in certain (almist random) cases there were no border for popups. Changed styles looks stable and do not show this random border miss. ## Type of change - [x] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a custom Waybar application launcher with a rocket icon, tooltip, and click-to-launch behavior. * **Refactor** * Improved launcher argument handling so each action consumes its intended parameter and remaining options are forwarded correctly. * **Style** * Consolidated tooltip and popup border declarations for consistent, solid borders. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
# Pull Request ## Description I spent some time trying to figure out why heic thumbnails were not working in dolphin and since most phones's default image format is heic I think its better someone else does not go through the same hassle as me. ## Type of change Please put an `x` in the boxes that apply: - [ ] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [x] All new and existing tests passed. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enhanced image format support and thumbnail generation for improved media handling across the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
added regex to dynamically replace "%s" to a query string. For Example: `https://google.com/search?q=%s` to `https://google.com/search?q=query+string`
…y url and query string dynamically (#1703) # Pull Request ## Description added regex to dynamically replace "%s" to a query string. For Example: `https://google.com/search?q=%s` to `https://google.com/search?q=query+string` **which enables complex query searches e.g. `https://example.com/search?q=%s?category=something`** ## Type of change Please put an `x` in the boxes that apply: - [ ] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [x] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [x] All new and existing tests passed. ## Screenshots (if appropriate) ## Additional context Add any other context about the problem here. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Web search queries are now URL-encoded and reliably open the intended search URL across providers. * Launcher messages now show and open the exact computed search URL so the opened page matches the displayed link. * **Chores** * Search provider entries standardized to use consistent query placeholders; file formatting corrected for consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
# Pull Request ## Description The Pull Request fixes a bug that causes the config restore to "hang" when the installation of the `hyprquery` packages is attempted. Previous approach calls the function `ensure_hyq` through command substitution, causing prints and interactive prompts caused by the package manager and `sudo` to not reach the user. The restore silently "fails" right after the last config deploy step, as the user has never been told that he is supposed to confirm the installation of the package. The pull request: - removes the need for confirmation from the package installation. - `hyprquery` seems required for HyDE to function properly moving forward, so there is no point in giving the user this choice in the first place - calls the `ensure_hyq` function directly and gets the path towards the hyq executable inside `hyprland_hook` - This turns the prints and output visible for the user and may still be required in the case of an `sudo` interactive prompt (timeout) I am not sure if there is a neater solution to this that can make use of command substitution again by ensuring the prints/targetted terminals in `ensure_hyq` work properly. But for the time being, this solution at least fixes the restore process. ## Type of change Please put an `x` in the boxes that apply: - [x] **Bug fix** (non-breaking change which fixes an issue) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below) ## Checklist Please put an `x` in the boxes that apply: - [x] I have read the [CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [x] My commit message follows the [commit guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added a changelog entry. - [ ] I have added necessary comments/documentation to my code. - [ ] I have added tests to cover my changes. - [x] I have tested my code locally and it works as expected. - [ ] All new and existing tests passed. ## Screenshots <img width="1920" height="1080" alt="image" src="https://github.com/user-attachments/assets/c0de45d3-6fa0-434c-bfb5-e222a4873ce8" /> ## Additional context I have been unsure under which prefix to create the changelog Entry (Core?). I apologize for any inconveniences this may causes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Streamlined executable detection and installation workflow. * **Improvements** * Package installations now proceed without confirmation prompts. * Reduced script output verbosity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
kRHYME7
approved these changes
Apr 21, 2026
kRHYME7
added a commit
that referenced
this pull request
Apr 30, 2026
This is an automated PR to promote changes from `rc` to `master`. Please review and test before merging. See [TESTING.md](./TESTING.md) for complete testing instructions. According to our release policy, this PR is expected to be merged on: **1st or 3rd Friday of the month** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. --- * chore Update CHANGELOG for v26.4.5 release (3d9d1d8) by Khing * chore chore: Release - dev → rc (#1718) (a42707c) by Khing * chore Merge branch 'rc' into dev (44976b1) by Khing * fix: Deprecate dontkillsteam (#1710) (7295838) by Shiba * chore chore: Release - dev → rc (#1702) (05bfe84) by Khing * fix issues on fresh install (16e2897) by kRHYME7 * chore Merge branch 'master' into rc (645f15c) by Khing * chore try to fix errors on fresh install (5aff210) by kRHYME7 * chore cleanup (92ed1f4) by kRHYME7 * chore See Changelog (8d34ef9) by kRHYME7 * chore Merge branch 'rc' into dev (0b3559d) by Khing * chore Merge branch 'master' into rc (663789f) by Khing * chore Merge branch 'rc' into dev (06f6f11) by Khing * chore Merge branch 'master' into rc (7fd0274) by Khing * fix: Fix hyprquery package install hangs restore (#1706) (265937d) by Khing * fix: Fix hyprquery package install hangs restore (364bc93) by PureFallen * chore pr (1a06650) by Khing * feat: Update `rofi.websearch` and `websearch.lst` to concatenate query url and query string dynamically (#1703) (e42e77b) by Khing * chore refactor: use `printf` instead of `echo` in rofi.websearch.sh (a18f9c7) by l-bloodstone * chore update: remove duplicate entry from websearch.lst (1b1a5d2) by l-bloodstone * chore refactor: rofi.websearch.sh to use url encoded query string (1965253) by l-bloodstone * chore update!: rofi.websearch.sh in order to make query URL dynamic (c2ce11d) by l-bloodstone * chore Merge branch 'HyDE-Project:dev' into dev (1047f2f) by l-bloodstone * chore update!: websearch.lst for new query url syntax (ecbf690) by l-bloodstone * chore Support heif/heic and other image thumbnails in dolphin. (#1470) (29dfac6) by Khing * chore Merge branch 'dev' into patch-1 (c06308f) by Khing * feat: waybar app launcher module (#1557) (8927f07) by Khing * chore Merge branch 'dev' into waybar-app-launcher (705fb43) by Khing * chore Windowrules blender (#1698) (7b3a8eb) by Khing * chore Merge branch 'dev' into windowrules_blender (07db31c) by Khing * chore Merge branch 'rc' into dev (641e88a) by Khing * chore chores: add precommit (#1694) (2d1f562) by Khing * chore Merge branch 'dev' into precommit (0851430) by Khing * chore Added experimental lua support in our scripts. (b0bcf58) by kRHYME7 * chore Merge branch 'dev' into windowrules_blender (1a199fc) by Khing * chore Merge branch 'dev' into precommit (7c1d73f) by Khing * chore Merge upstream/dev into windowrules_blender (835517a) by Kminek42 * feat: add floating rules for Blender Render window (01d9a05) by Kminek42 * feat: add opacity rule for blender to disable transparency (d4b181a) by Kminek42 * chore Update CONTRIBUTING.md (8c4ee77) by Rubin Bhandari * chore Update CONTRIBUTING.md (1437b21) by Rubin Bhandari * chore Merge branch 'dev' into precommit (d15dc20) by Rubin Bhandari * chore chores: add precommit (bd0c6b2) by Rubin Bhandari * chore Merge branch 'dev' into waybar-app-launcher (5955c7f) by Khing * chore Merge branch 'dev' into patch-1 (f17cd4c) by Khing * fix: dont use `shift` in default case (7032544) by Ilya Bogdanov * feat: rename waybar module `custom/applauncher` -> `custom/app-launcher` (3208d23) by Ilya Bogdanov * fix: add quotes as suggested by @coderabbitai (69e069e) by Ilya Bogdanov * feat: new `applauncher` module for waybar (58322e7) by Ilya Bogdanov * fix: change border to one prop (4a3b428) by Ilya Bogdanov * chore Merge branch 'dev' into patch-1 (51ef10b) by Khing * chore Merge branch 'dev' into patch-1 (039d3ed) by Khing * chore Merge branch 'dev' into patch-1 (1eb5776) by Khing * chore Merge branch 'dev' into patch-1 (13b33fb) by Khing * chore move kimageformats to pkg_extra (3bb632e) by JunaidQrysh * chore Merge branch 'dev' into patch-1 (efc8af6) by Khing * chore Merge branch 'dev' into patch-1 (0819935) by Khing --- Please review the changes carefully before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated PR to promote changes from
devtorc.Please review and test before merging.
See TESTING.md for complete testing instructions.
According to our release policy, this PR is expected to be merged during: Freeze Week (see release policy)
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the project.
rofi.websearchandwebsearch.lstto concatenate query url and query string dynamically (feat: Updaterofi.websearchandwebsearch.lstto concatenate query url and query string dynamically #1703) (e42e77b) by Khingprintfinstead ofechoin rofi.websearch.sh (a18f9c7) by l-bloodstoneshiftin default case (7032544) by Ilya Bogdanovcustom/applauncher->custom/app-launcher(3208d23) by Ilya Bogdanovapplaunchermodule for waybar (58322e7) by Ilya BogdanovPlease review the changes carefully before merging.