feat: refactor template for Astal and add split style support#5
Open
GustavoBorges13 wants to merge 6 commits intoHyDE-Project:mainfrom
Open
feat: refactor template for Astal and add split style support#5GustavoBorges13 wants to merge 6 commits intoHyDE-Project:mainfrom
GustavoBorges13 wants to merge 6 commits intoHyDE-Project:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughUpdated README to document an Astal-based HyprPanel workflow ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hyprpanel_default.dcol`:
- Around line 12-13: The "scrollbar" and "separator" color token values use
malformed placeholders "#<$wallbash_2xa2>" and "#<$wallbash_2xa8>" which include
an extra "$"; update those token strings in hyprpanel_default.dcol (the
"scrollbar" and "separator" entries) to use the correct template format
"#<wallbash_2xa2>" and "#<wallbash_2xa8>" so they match the other Wallbash
tokens and will be substituted correctly.
In `@hyprpanel_split.dcol`:
- Around line 12-13: The scrollbar and separator token values use a malformed
placeholder syntax ("#<$wallbash_2xa2>" and "#<$wallbash_2xa8>"); update these
two entries (keys "scrollbar" and "separator") to use the same placeholder
format as the other tokens in the file (e.g., "#{wallbash_2xa2}" and
"#{wallbash_2xa8}" or whatever exact bracket/hash pattern is used elsewhere) so
the color placeholders resolve consistently.
In `@README.md`:
- Line 7: The README has a heading "Wallbash Template for HyprPanel" marked as
H3 (###) that jumps from the H1 above; change that heading to H2 (##) so heading
levels are sequential (H1 → H2) and comply with markdown lint rules by replacing
the "### Wallbash Template for HyprPanel" line with "## Wallbash Template for
HyprPanel".
- Around line 18-30: Update README references to match the shipped filenames:
replace occurrences of "hyprpanel.dcol" with "hyprpanel_default.dcol" (e.g., in
the paragraph listing templates and the Usage section) so the documented
template names exactly match the actual files `hyprpanel_default.dcol` and
`hyprpanel_split.dcol`; ensure all mentions, including the list entry and
download instruction, consistently use `hyprpanel_default.dcol` and
`hyprpanel_split.dcol`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dd08daa9-a312-469f-bcc2-85af9bd9b9be
📒 Files selected for processing (4)
README.mdhyprpanel.dcolhyprpanel_default.dcolhyprpanel_split.dcol
💤 Files with no reviewable changes (1)
- hyprpanel.dcol
There was a problem hiding this comment.
🧹 Nitpick comments (2)
hyprpanel.dcol (2)
389-389: Minor formatting inconsistency: missing space after colon.This line lacks a space after the colon, unlike all other entries in the file.
🧹 Suggested fix
- "theme.bar.buttons.modules.cava.text":"#<wallbash_2xa8>", + "theme.bar.buttons.modules.cava.text": "#<wallbash_2xa8>",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@hyprpanel.dcol` at line 389, The entry "theme.bar.buttons.modules.cava.text":"#<wallbash_2xa8>" is missing a space after the colon; update this key-value pair (the "theme.bar.buttons.modules.cava.text" mapping) to include a single space after the colon so it matches the formatting of other entries (e.g., "theme.bar.buttons.modules.cava.text": "#<wallbash_2xa8>").
110-110: Minor formatting inconsistency: double space before value.This line has an extra space before the value, unlike other entries. Consider aligning for consistency.
🧹 Suggested fix
- "theme.bar.menus.menu.clock.weather.thermometer.extremelycold": "#<wallbash_2xa9>", + "theme.bar.menus.menu.clock.weather.thermometer.extremelycold": "#<wallbash_2xa9>",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@hyprpanel.dcol` at line 110, The theme entry "theme.bar.menus.menu.clock.weather.thermometer.extremelycold" has an extra space between the colon and its value; update that line to use a single space after the colon to match other entries (i.e., change the double space before "#<wallbash_2xa9>" to a single space) so the formatting is consistent with the rest of the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@hyprpanel.dcol`:
- Line 389: The entry "theme.bar.buttons.modules.cava.text":"#<wallbash_2xa8>"
is missing a space after the colon; update this key-value pair (the
"theme.bar.buttons.modules.cava.text" mapping) to include a single space after
the colon so it matches the formatting of other entries (e.g.,
"theme.bar.buttons.modules.cava.text": "#<wallbash_2xa8>").
- Line 110: The theme entry
"theme.bar.menus.menu.clock.weather.thermometer.extremelycold" has an extra
space between the colon and its value; update that line to use a single space
after the colon to match other entries (i.e., change the double space before
"#<wallbash_2xa9>" to a single space) so the formatting is consistent with the
rest of the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6bb48eab-7837-4081-80d2-54b84552f49b
📒 Files selected for processing (3)
README.mdhyprpanel.dcolhyprpanel_split.dcol
✅ Files skipped from review due to trivial changes (1)
- hyprpanel_split.dcol
🚧 Files skipped from review as they are similar to previous changes (1)
- README.md
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hyprpanel.dcol`:
- Around line 20-22: theme.bar.menus.background and
theme.bar.menus.popover.background currently reuse the same token as the bar
background (#<wallbash_pry1>), so replace one or both with a distinct, darker
token (e.g., introduce #<wallbash_menu_bg> or reuse an existing darker variable)
to create contrast for menu surfaces; update the entries for
theme.bar.menus.background and theme.bar.menus.popover.background to reference
that new/darker token and ensure any dependent menu color keys inherit from the
new token rather than #<wallbash_pry1>.
- Around line 325-326: This template omits the theme key that controls button
layout, so imported themes can inherit the wrong button structure; add the key
"theme.bar.buttons.style" with the value "default" alongside the existing button
entries (e.g., near "theme.bar.buttons.workspaces.numbered_active_text_color"
and "theme.bar.buttons.modules.microphone.border") to explicitly set the default
button style for this template.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9cdd3cb1-73d1-4699-adcd-09b2b3ab56b2
📒 Files selected for processing (2)
hyprpanel.dcolhyprpanel_split.dcol
✅ Files skipped from review due to trivial changes (1)
- hyprpanel_split.dcol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4
I rewrote the Wallbash template from scratch to make it fully compatible with the new Astal-based HyprPanel version instead of the old AGS backend.
Changes made:
.dcolto useastal -i hyprpanel useTheme.hyprpanel.dcol) and one for the split button style (hyprpanel_split.dcol).README.mdcomprehensively to guide users on which template to use, what directory to place it in, and how to work around the Matugen override using a script.Here is the preview and the checklist of the tested modules:
✅ Standard Modules
🔧 Basic Modules
Template 1: hyprpanel.dcol
Without borders (not transparent bar x transparent bar)
With borders (not transparent bar x transparent bar)
Template 2: hyprpanel_split.dcol
Without borders (not transparent bar x transparent bar)
With borders (not transparent bar x transparent bar)
🧩 Custom Modules (not included)
HyDE-Menugpugputempgamemode📂 Menus
🖼️ Click to expand Menu Screenshots
Summary by CodeRabbit
Documentation
New Features
Style / Theming