Sorting out Model Components

[HenryGeorgist]

Is Model.Functions or Functions the most up to date code? Is there stuff in Model that is necessary or is it the old code that is partially refactored?

[HenryGeorgist]

@codymccoy @rnugent3 I could use some direction here, I think the entire Model project is more or less defunct - is that right?

[codymccoy]

I am not sure what you mean by "defunct". We are currently referencing the model from the VM. It will be defunct if you make a new model and swap it out.

[HenryGeorgist]

I saw that the model is included in the resources of the VM, and I found many classes that are never actually referenced. I struggled to find any classes that were specifically referenced in the VM. Many of the references point to things like Functions."star" or Statistics."star" but not Model."star"

[codymccoy]

I did a little poking around. The class in the model called "IFdaFunctionFactory" is used all over the view model.

[HenryGeorgist]

@codymccoy I guess what I am concerned about is that I want to minimize your pain. I am trying to find the right classes to cover in the new model, and the right classes in the old model and related libraries to deprecate. I keep finding what seem to be code remnants so I am trying to reduce those to make sure I can efficiently support you.

[HenryGeorgist]

ah. That explains it. Everything is built through the factory. Perfect. Thanks!

[HenryGeorgist]

Based on @codymccoy 's answer i think we can take the new FDA model, implement the IFDAFunction interface on the UncertaintyPairedData and PairedData using an adapter, and then update the IFDAFunctionFactory to substitute the entire FDA model out in pretty much one fell swoop.
I would reccomend we then deprecate the IFDAFunctionFactory class, and fix the 27 references to point directly at the new FDA model and then delete the entire model project. Thoughts? @rnugent3

[codymccoy]

Sounds good to me.

[rnugent3]

model has been deleted

[rnugent3]

and replaced with fda-model