Skip to content

Feature/shar 285 OIDC pkce#280

Merged
MikeNeilson merged 13 commits intomainfrom
feature/SHAR-285-OIDC-PKCE
Oct 27, 2025
Merged

Feature/shar 285 OIDC pkce#280
MikeNeilson merged 13 commits intomainfrom
feature/SHAR-285-OIDC-PKCE

Conversation

@MikeNeilson
Copy link
Copy Markdown
Collaborator

@MikeNeilson MikeNeilson commented Oct 20, 2025

TODO:

  • Processing of extensions to enable use of kc_idp_hint for CWBI keycloak derived from OpenAPI specification (possible that should be handled upstream and passed in.) - will handle in follow up PR, this is already large)
  • Changes for any feedback.
  • Attempted usage with hec-client-server Login Dialog Scaffold to verify implementation details and behavior.
  • Remove System.out.println statement, or change to logger.

While a little drastic to remove the "Discovery Provider", to be honest I forgot about it when I started the work and by the time I found it again all of the same work likely would've been required and I don't see a way that easily integrates into the login dialog.

@MikeNeilson
Copy link
Copy Markdown
Collaborator Author

Also need to improve exactly how the wellknown is processed, currently two requests to that endpoint are made when it should really just be one. Was keeping it simple while I got the initial setup to work.

I also expect the new test to fail in the action as the browser won't be available and thus it should get stuck. need to determine exactly how to deal with that.

@MikeNeilson MikeNeilson requested a review from sevans40 October 20, 2025 17:28
@MikeNeilson
Copy link
Copy Markdown
Collaborator Author

MikeNeilson commented Oct 20, 2025

Seeing that it failed (got stuck) in the location I expected, I'm now implementing a Consumer to handle any auth callback. It will default to do nothing so it's easy to inject in the existing code.

@MikeNeilson
Copy link
Copy Markdown
Collaborator Author

This is ready for additional review. Changes to handle extensions, like the kc_idp_hint query parameter will be done in follow up PRs

Copy link
Copy Markdown
Collaborator Author

@MikeNeilson MikeNeilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take me a bit to implement all of that. thanks for the review.

@MikeNeilson MikeNeilson merged commit 0b81c12 into main Oct 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve setup of SSLContexts Rename CWBI Auth to OIDC Auth or similar

2 participants